Skip to content

Fixes data-latex content for Table Rows #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zorkow merged 13 commits into from
Aug 17, 2026
Merged

Fixes data-latex content for Table Rows #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c169f74
fix latex attributes for rows in array-like expressions
zorkow Jul 12, 2026
1d90849
update tests to for new LaTeX output in rows
zorkow Jul 12, 2026
fd5569d
ensure labels will get the right latex attribute
zorkow Jul 14, 2026
3883836
extend correct row handling to multline environments
zorkow Jul 14, 2026
cb86ab3
fixes missing color elements in rows
zorkow Jul 21, 2026
85591c7
fixes issue with column template that garbles data-latex attribute
zorkow Jul 21, 2026
ee4d360
fixes also the nested array issue
zorkow Jul 21, 2026
a304ee3
ensure that ref elements actually get a data-latex attribute
zorkow Jul 27, 2026
43ad772
mrows with ref commands get the correct data-latex
zorkow Jul 27, 2026
546c77f
fixes nested table problem
zorkow Jul 30, 2026
0d84355
Merge pull request #1529 from mathjax/fix/table_latex_encore
zorkow Jul 30, 2026
c618121
Merge branch 'develop' into fix/table_latex
zorkow Aug 7, 2026
4a09165
incorporate review suggestions except for parsing loop
zorkow Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions testsuite/tests/input/tex/Ams.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,4 +1038,12 @@ describe('Ams symbols', () => {

/**********************************************************************************/

describe('Ams Issues', () => {
it('Array with Tag', () => {
expect(tex2mml('\\begin{array}{c}a \\end{array}\\tag{1}')).toMatchSnapshot();
});
});

/**********************************************************************************/

afterAll(() => getTokens('ams'));
2 changes: 1 addition & 1 deletion testsuite/tests/input/tex/SetOptions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('Setoptions', () => {
).toMatchSnapshot();
});

test('Set pacjage regexp option', () => {
test('Set package regexp option', () => {
expect(
tex2mml(
'\\setOptions[ams]{operatornamePattern=/^[a-z0-9]+/} \\operatorname{ab1}'
Expand Down
367 changes: 195 additions & 172 deletions testsuite/tests/input/tex/__snapshots__/Ams.test.ts.snap
View file
Open in desktop

Large diffs are not rendered by default.

66 changes: 33 additions & 33 deletions testsuite/tests/input/tex/__snapshots__/Amscd.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`AmsCD AmsCD-1 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B">
Comment thread
zorkow marked this conversation as resolved.
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -20,7 +20,7 @@ exports[`AmsCD AmsCD-1 1`] = `
<mi data-latex="B">B</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;">
<mtd>
<mrow>
<mo minsize="1.75em" symmetric="true" lspace="0" rspace="0">&#x2193;</mo>
Expand Down Expand Up @@ -60,7 +60,7 @@ exports[`AmsCD AmsCD-1 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="C&amp;&amp;D">
<mtd>
<mi data-latex="C">C</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -84,7 +84,7 @@ exports[`AmsCD AmsCD-1 1`] = `
exports[`AmsCD AmsCD-2 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A @&lt;&lt;&lt; B @&gt;&gt;&gt; C\\\\@. @| @AAA\\\\@. D @= E\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A @&lt;&lt;&lt; B @&gt;&gt;&gt; C\\\\@. @| @AAA\\\\@. D @= E\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B&amp;&amp;C">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand Down Expand Up @@ -112,7 +112,7 @@ exports[`AmsCD AmsCD-2 1`] = `
<mi data-latex="C">C</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;&amp;&amp;">
<mtd></mtd>
<mtd></mtd>
<mtd>
Expand All @@ -124,7 +124,7 @@ exports[`AmsCD AmsCD-2 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;D&amp;&amp;E">
<mtd>
<mpadded height="8.5pt" depth="2pt"></mpadded>
</mtd>
Expand All @@ -146,7 +146,7 @@ exports[`AmsCD AmsCD-2 1`] = `
exports[`AmsCD AmsCD-3 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A @&gt;a&gt;b&gt; B\\\\@VlVrV @AlArA\\\\C @&lt;a&lt;b&lt; D\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A @&gt;a&gt;b&gt; B\\\\@VlVrV @AlArA\\\\C @&lt;a&lt;b&lt; D\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -166,7 +166,7 @@ exports[`AmsCD AmsCD-3 1`] = `
<mi data-latex="B">B</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;">
<mtd>
<mrow>
<mstyle displaystyle="false" scriptlevel="1" data-latex="\\scriptstyle\\raise.125em{\\vcenter{\\llap{l}}}">
Expand Down Expand Up @@ -232,7 +232,7 @@ exports[`AmsCD AmsCD-3 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="C&amp;&amp;D">
<mtd>
<mi data-latex="C">C</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -259,7 +259,7 @@ exports[`AmsCD AmsCD-3 1`] = `
exports[`AmsCD AmsCD-4 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A @&gt;&gt;&gt; B@&gt;\\text{very long label}&gt;&gt;C\\\\@VVV @VVV @VVV\\\\D @&gt;&gt;&gt; E@&gt;&gt;&gt; F\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A @&gt;&gt;&gt; B@&gt;\\text{very long label}&gt;&gt;C\\\\@VVV @VVV @VVV\\\\D @&gt;&gt;&gt; E@&gt;&gt;&gt; F\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B&amp;&amp;C">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand Down Expand Up @@ -287,7 +287,7 @@ exports[`AmsCD AmsCD-4 1`] = `
<mi data-latex="C">C</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;&amp;&amp;">
<mtd>
<mo minsize="1.75em" symmetric="true" lspace="0" rspace="0">&#x2193;</mo>
</mtd>
Expand All @@ -301,7 +301,7 @@ exports[`AmsCD AmsCD-4 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="D&amp;&amp;E&amp;&amp;F">
<mtd>
<mi data-latex="D">D</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand Down Expand Up @@ -336,7 +336,7 @@ exports[`AmsCD AmsCD-4 1`] = `
exports[`AmsCD AmsCD-5 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A @&gt;&gt;&gt; B @&gt;{\\text{very long label}}&gt;&gt; C \\\\@VVV @VVV @VVV \\\\D @&gt;&gt;&gt; E @&gt;{\\phantom{\\text{very long label}}}&gt;&gt; F\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A @&gt;&gt;&gt; B @&gt;{\\text{very long label}}&gt;&gt; C \\\\@VVV @VVV @VVV \\\\D @&gt;&gt;&gt; E @&gt;{\\phantom{\\text{very long label}}}&gt;&gt; F\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B&amp;&amp;C">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand Down Expand Up @@ -366,7 +366,7 @@ exports[`AmsCD AmsCD-5 1`] = `
<mi data-latex="C">C</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;&amp;&amp;">
<mtd>
<mo minsize="1.75em" symmetric="true" lspace="0" rspace="0">&#x2193;</mo>
</mtd>
Expand All @@ -380,7 +380,7 @@ exports[`AmsCD AmsCD-5 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="D&amp;&amp;E&amp;&amp;F">
<mtd>
<mi data-latex="D">D</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand Down Expand Up @@ -421,7 +421,7 @@ exports[`AmsCD AmsCD-5 1`] = `
exports[`AmsCD AmsCD-6 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A @&gt;&gt;&gt; B @&gt;{\\text{very long label}}&gt;&gt; C \\\\@VVV @VVV @VVV \\\\D @&gt;&gt;&gt; E @&gt;{\\rlap{\\scriptstyle{\\ \\ \\ \\text{shorter}}}\\phantom{\\text{very long label}}}&gt;&gt; F\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A @&gt;&gt;&gt; B @&gt;{\\text{very long label}}&gt;&gt; C \\\\@VVV @VVV @VVV \\\\D @&gt;&gt;&gt; E @&gt;{\\rlap{\\scriptstyle{\\ \\ \\ \\text{shorter}}}\\phantom{\\text{very long label}}}&gt;&gt; F\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B&amp;&amp;C">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand Down Expand Up @@ -451,7 +451,7 @@ exports[`AmsCD AmsCD-6 1`] = `
<mi data-latex="C">C</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;&amp;&amp;">
<mtd>
<mo minsize="1.75em" symmetric="true" lspace="0" rspace="0">&#x2193;</mo>
</mtd>
Expand All @@ -465,7 +465,7 @@ exports[`AmsCD AmsCD-6 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="D&amp;&amp;E&amp;&amp;F">
<mtd>
<mi data-latex="D">D</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand Down Expand Up @@ -516,7 +516,7 @@ exports[`AmsCD AmsCD-6 1`] = `
exports[`AmsCD AmsCD-both 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\minCDarrowheight{4cm}\\minCDarrowwidth{5cm}\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\minCDarrowheight{4cm}\\minCDarrowwidth{5cm}\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -533,7 +533,7 @@ exports[`AmsCD AmsCD-both 1`] = `
<mi data-latex="B">B</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;">
<mtd>
<mrow>
<mo minsize="4cm" symmetric="true" lspace="0" rspace="0">&#x2193;</mo>
Expand Down Expand Up @@ -573,7 +573,7 @@ exports[`AmsCD AmsCD-both 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="C&amp;&amp;D">
<mtd>
<mi data-latex="C">C</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -597,7 +597,7 @@ exports[`AmsCD AmsCD-both 1`] = `
exports[`AmsCD AmsCD-height 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\minCDarrowheight{4cm}\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\minCDarrowheight{4cm}\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -614,7 +614,7 @@ exports[`AmsCD AmsCD-height 1`] = `
<mi data-latex="B">B</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;">
<mtd>
<mrow>
<mo minsize="4cm" symmetric="true" lspace="0" rspace="0">&#x2193;</mo>
Expand Down Expand Up @@ -654,7 +654,7 @@ exports[`AmsCD AmsCD-height 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="C&amp;&amp;D">
<mtd>
<mi data-latex="C">C</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -678,7 +678,7 @@ exports[`AmsCD AmsCD-height 1`] = `
exports[`AmsCD AmsCD-width 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\minCDarrowwidth{5cm}\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\minCDarrowwidth{5cm}\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -695,7 +695,7 @@ exports[`AmsCD AmsCD-width 1`] = `
<mi data-latex="B">B</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;">
<mtd>
<mrow>
<mo minsize="1.75em" symmetric="true" lspace="0" rspace="0">&#x2193;</mo>
Expand Down Expand Up @@ -735,7 +735,7 @@ exports[`AmsCD AmsCD-width 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="C&amp;&amp;D">
<mtd>
<mi data-latex="C">C</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -759,7 +759,7 @@ exports[`AmsCD AmsCD-width 1`] = `
exports[`AmsCD Entry with prime (#3373) 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A' @&gt;&gt;&gt; B\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A' @&gt;&gt;&gt; B\\end{CD}">
<mtr>
<mtr data-latex="&amp;&amp;B">
<mtd>
<msup>
<mi data-latex="A">A</mi>
Expand All @@ -786,7 +786,7 @@ exports[`AmsCD Entry with prime (#3373) 1`] = `
exports[`AmsCD Options Hide Horizontal Labels 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A @&gt;a&gt;&gt; B\\\\@VVbV @VVcV\\\\C @&gt;d&gt;&gt; D\\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -805,7 +805,7 @@ exports[`AmsCD Options Hide Horizontal Labels 1`] = `
<mi data-latex="B">B</mi>
</mtd>
</mtr>
<mtr>
<mtr data-latex="&amp;&amp;&amp;">
<mtd>
<mrow>
<mo minsize="1.75em" symmetric="true" lspace="0" rspace="0">&#x2193;</mo>
Expand Down Expand Up @@ -845,7 +845,7 @@ exports[`AmsCD Options Hide Horizontal Labels 1`] = `
</mtd>
<mtd></mtd>
</mtr>
<mtr>
<mtr data-latex="C&amp;&amp;D">
<mtd>
<mi data-latex="C">C</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -871,7 +871,7 @@ exports[`AmsCD Options Hide Horizontal Labels 1`] = `
exports[`AmsCD Spaces 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A @ &gt; x &gt; &gt; B \\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A @ &gt; x &gt; &gt; B \\end{CD}">
<mtr>
<mtr data-latex="A&amp;&amp;B">
<mtd>
<mi data-latex="A">A</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand All @@ -895,7 +895,7 @@ exports[`AmsCD Spaces 1`] = `
exports[`AmsCD Suspicious Return 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD}A @Ra&gt;&gt; BaD\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD}A @Ra&gt;&gt; BaD\\end{CD}">
<mtr>
<mtr data-latex="A@R a&gt;&gt;B a D">
<mtd>
<mi data-latex="A">A</mi>
<mo data-latex="@">@</mo>
Expand Down
2 changes: 1 addition & 1 deletion testsuite/tests/input/tex/__snapshots__/Autoload.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`Autoload Autoload environment 1`] = `
"<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{CD} a @&gt;&gt;&gt; b\\end{CD}" display="block">
<mtable columnspacing="5pt" rowspacing="5pt" displaystyle="true" data-latex="\\begin{CD} a @&gt;&gt;&gt; b\\end{CD}">
<mtr>
<mtr data-latex="a&amp;&amp;b">
<mtd>
<mi data-latex="a">a</mi>
<mpadded height="8.5pt" depth="2pt"></mpadded>
Expand Down
Loading