Repository navigation
Mutable-Immutable - #4074
Mutable-Immutable#4074DanUTG wants to merge 5 commits into
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution meets the functional requirements: sorted_variables contains the required mutable and immutable lists and groups all eight variables correctly. The lint run reports formatting issues on app/main.py:19 (spaces inside braces and a line exceeding 79 characters); these are non-blocking and can be cleaned up by removing the inner spaces and splitting the expression across lines. Tests were not confirmed because the workflow stopped at lint, but no functional issue was identified in the available review.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
What "reviewers tab"? Update: I think that I found it. It had no label. |
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am approving this solution because sorted_variables includes the required mutable and immutable lists with all eight variables grouped correctly. flake8 reports whitespace, continuation-indentation, and line-length issues around lines 13, 16, and 17; these are style issues rather than blockers to the required functionality. Tests were not assessed because the workflow stopped at linting, but no functional issue was identified in the reviewed code.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
I made the changes requested and pushed them as requested. The flake8 issues were with the downloaded code, not the changes I made. Once again, hours of fighting with GitHub over a few minutes code change. |
No description provided.