Skip to content

Mutable-Immutable - #4074

Open
DanUTG wants to merge 5 commits into
mate-academy:masterfrom
DanUTG:master
Open

DanUTG wants to merge 5 commits into
mate-academy:masterfrom
DanUTG:master

Conversation

@DanUTG

@DanUTG DanUTG commented Nov 13, 2026

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution meets the functional requirements: sorted_variables contains the required mutable and immutable lists and groups all eight variables correctly. The lint run reports formatting issues on app/main.py:19 (spaces inside braces and a line exceeding 79 characters); these are non-blocking and can be cleaned up by removing the inner spaces and splitting the expression across lines. Tests were not confirmed because the workflow stopped at lint, but no functional issue was identified in the available review.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example ↩

  2. Re-request AI review example ↩

  3. Add AI review comments example ↩

@DanUTG

DanUTG commented Nov 13, 2026 •

Copy link
Copy Markdown
Author

What "reviewers tab"? Update: I think that I found it. It had no label.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving this solution because sorted_variables includes the required mutable and immutable lists with all eight variables grouped correctly. flake8 reports whitespace, continuation-indentation, and line-length issues around lines 13, 16, and 17; these are style issues rather than blockers to the required functionality. Tests were not assessed because the workflow stopped at linting, but no functional issue was identified in the reviewed code.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example ↩

  2. Re-request AI review example ↩

  3. Add AI review comments example ↩

@DanUTG

DanUTG commented Nov 13, 2026

Copy link
Copy Markdown
Author

I made the changes requested and pushed them as requested. The flake8 issues were with the downloaded code, not the changes I made. Once again, hours of fighting with GitHub over a few minutes code change.

@DanUTG DanUTG closed this Nov 13, 2026
@DanUTG DanUTG reopened this Nov 13, 2026
Your Name and others added 2 commits November 13, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants