Skip to content

agent-feedback: mint a distinct renderId per render - #39

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-scan-feedback-dgfb4e
Aug 21, 2026
Merged

agent-feedback: mint a distinct renderId per render#39
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-scan-feedback-dgfb4e

Conversation

@DylanPiercey

@DylanPiercey DylanPiercey commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

One new item: two Marko 6 render() calls in one test share a $global.renderId, so ids generated by <id> collide and the second render is unqueryable.

@changeset-bot

changeset-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8ee4ab4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 59 minutes

Limit details: You’ve used all 2 included reviews currently available. Your 57 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

You’re in a promotional period — use the checkbox below to run this review for free:

  • Run review for free

On-demand reviews are free for the next 31 days. After that, they cost $0.25 per reviewed file.

How can I continue?

Run this review now using the option above, or comment @coderabbitai review --use-credits.

You can also wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c05594e6-159d-4e25-bf64-5d1a1fc53323

📥 Commits

Reviewing files that changed from the base of the PR and between 3116e92 and 8ee4ab4.

📒 Files selected for processing (1)
  • agent-feedback/items/2026-08-20-unique-render-id-per-marko-6-render.md

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.42%. Comparing base (3116e92) to head (8ee4ab4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   65.42%   65.42%           
=======================================
  Files           3        3           
  Lines         188      188           
  Branches       50       50           
=======================================
  Hits          123      123           
  Misses         44       44           
  Partials       21       21           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey
DylanPiercey merged commit 525c45b into main Aug 21, 2026
11 checks passed
@DylanPiercey DylanPiercey changed the title agent-feedback: a second render in one test is unqueryable agent-feedback: mint a distinct renderId per render Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant