Skip to content

Handle new CommentKind variants to unblock cross-platform gem build - #15

Merged
marcoroth merged 3 commits into
bot-dep-oxc-0.152.0from
copilot/fix-github-actions-job
Sep 28, 2026
Merged

marcoroth merged 3 commits into
bot-dep-oxc-0.152.0from
copilot/fix-github-actions-job

Conversation

Copilot AI commented Sep 28, 2026 •

Copy link
Copy Markdown

The build started failing after upgrading oxc because rust/src/parse.rs no longer exhaustively matched CommentKind. New HtmlOpen/HtmlClose variants triggered E0004 during Rust compilation in the GitHub Actions packaging job.

  • Parser compatibility update

    • Extend comment-kind mapping in collect_comments to handle newly introduced oxc variants.
    • Map HtmlOpen and HtmlClose to Ruby-facing "Line" comments to preserve existing comment typing semantics.
  • Regression coverage

    • Add focused parser tests for HTML-style comments to ensure both open (<!--) and close (-->, script mode) forms are serialized as line comments.
kind: match comment.kind {
  CommentKind::Line => "Line",
  CommentKind::SingleLineBlock | CommentKind::MultiLineBlock => "Block",
  CommentKind::HtmlOpen | CommentKind::HtmlClose => "Line",
},

Copilot AI and others added 2 commits September 28, 2026 16:02
Co-authored-by: marcoroth <6411752+marcoroth@users.noreply.github.com>
Co-authored-by: marcoroth <6411752+marcoroth@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Handle new CommentKind variants to unblock cross-platform gem build Sep 28, 2026
Copilot AI requested a review from marcoroth September 28, 2026 16:07
@marcoroth
marcoroth removed this pull request from stack #16 September 28, 2026 16:08
@marcoroth
marcoroth marked this pull request as ready for review September 28, 2026 16:08
@marcoroth
marcoroth merged commit 5436dea into bot-dep-oxc-0.152.0 Sep 28, 2026
11 checks passed
@marcoroth
marcoroth deleted the copilot/fix-github-actions-job branch September 28, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants