Handle new CommentKind variants to unblock cross-platform gem build - #15
Merged
Merged
Conversation
Co-authored-by: marcoroth <6411752+marcoroth@users.noreply.github.com>
Co-authored-by: marcoroth <6411752+marcoroth@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job
Handle new Sep 28, 2026
CommentKind variants to unblock cross-platform gem build
marcoroth
removed this pull request from stack #16
September 28, 2026 16:08
marcoroth
marked this pull request as ready for review
September 28, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build started failing after upgrading
oxcbecauserust/src/parse.rsno longer exhaustively matchedCommentKind. NewHtmlOpen/HtmlClosevariants triggeredE0004during Rust compilation in the GitHub Actions packaging job.Parser compatibility update
collect_commentsto handle newly introducedoxcvariants.HtmlOpenandHtmlCloseto Ruby-facing"Line"comments to preserve existing comment typing semantics.Regression coverage
<!--) and close (-->, script mode) forms are serialized as line comments.