Skip to content

Bump oxc to 0.152.0 - #14

Merged
marcoroth merged 2 commits into
mainfrom
bot-dep-oxc-0.152.0
Sep 28, 2026
Merged

marcoroth merged 2 commits into
mainfrom
bot-dep-oxc-0.152.0

Conversation

@marcoroth

Copy link
Copy Markdown
Owner

Update the embedded oxc dependency from 0.151.0 to 0.152.0.

The gem version tracks the oxc version it packages, so this also bumps the gem from 0.151.0 to 0.152.0.

Warning

The gem did not build or test cleanly against this version, so this PR is a draft.
Something upstream changed in a way this gem has to be adapted to.

Verification output
cargo build --release --locked
   Compiling hashbrown v0.17.1
   Compiling oxc_data_structures v0.152.0
   Compiling oxc_ast_macros v0.152.0
   Compiling oxc_sourcemap v9.0.0
   Compiling indexmap v2.14.0
   Compiling oxc_estree v0.152.0
   Compiling cbindgen v0.29.4
   Compiling oxc_allocator v0.152.0
   Compiling oxc_str v0.152.0
   Compiling oxc_span v0.152.0
   Compiling oxc_syntax v0.152.0
   Compiling oxc_diagnostics v0.152.0
   Compiling oxc_regular_expression v0.152.0
   Compiling oxc_ast v0.152.0
   Compiling oxc_compat v0.152.0
   Compiling oxc-ruby-ffi v0.0.0 (/home/runner/work/oxc-ruby/oxc-ruby/rust)
   Compiling oxc_ecmascript v0.152.0
   Compiling oxc_ast_visit v0.152.0
   Compiling oxc_parser v0.152.0
   Compiling oxc_semantic v0.152.0
   Compiling oxc_isolated_declarations v0.152.0
   Compiling oxc_traverse v0.152.0
   Compiling oxc_mangler v0.152.0
   Compiling oxc_codegen v0.152.0
   Compiling oxc_transformer v0.152.0
   Compiling oxc_minifier v0.152.0
   Compiling oxc_transformer_plugins v0.152.0
   Compiling oxc v0.152.0
error[E0004]: non-exhaustive patterns: `CommentKind::HtmlOpen` and `CommentKind::HtmlClose` not covered
  --> src/parse.rs:68:19
   |
68 |       kind: match comment.kind {
   |                   ^^^^^^^^^^^^ patterns `CommentKind::HtmlOpen` and `CommentKind::HtmlClose` not covered
   |
note: `CommentKind` defined here
  --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/oxc_ast-0.152.0/src/ast/comment.rs:13:1
   |
13 | pub enum CommentKind {
   | ^^^^^^^^^^^^^^^^^^^^
...
25 |     HtmlOpen = 4,
   |     -------- not covered
...
28 |     HtmlClose = 3,
   |     --------- not covered
   = note: the matched value is of type `CommentKind`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern, a match arm with multiple or-patterns as shown, or multiple match arms
   |
70 ~         CommentKind::SingleLineBlock | CommentKind::MultiLineBlock => "Block",
71 ~         CommentKind::HtmlOpen | CommentKind::HtmlClose => todo!(),
   |

For more information about this error, try `rustc --explain E0004`.
error: could not compile `oxc-ruby-ffi` (lib) due to 1 previous error
rake aborted!
Command failed with status (101): [cargo build --release --locked]
/home/runner/work/oxc-ruby/oxc-ruby/Rakefile:57:in 'block (2 levels) in <top (required)>'
/home/runner/work/oxc-ruby/oxc-ruby/Rakefile:57:in 'Dir.chdir'
/home/runner/work/oxc-ruby/oxc-ruby/Rakefile:57:in 'block in <top (required)>'
/home/runner/work/oxc-ruby/oxc-ruby/vendor/bundle/ruby/4.0.0/gems/rake-13.4.2/exe/rake:27:in '<top (required)>'
/opt/hostedtoolcache/Ruby/4.0.6/x64/bin/bundle:25:in '<main>'
Tasks: TOP => test => compile => cargo
(See full trace by running task with --trace)

This PR was created automatically by the upstream workflow.

Update the embedded oxc dependency from 0.151.0 to 0.152.0 and release it as
gem v0.152.0.

https://github.com/oxc-project/oxc/releases/tag/crates_v0.152.0
@marcoroth
marcoroth added this pull request to stack #16 September 28, 2026 15:57
@marcoroth
marcoroth removed this pull request from stack #16 September 28, 2026 16:08
…#15)

The build started failing after upgrading `oxc` because
`rust/src/parse.rs` no longer exhaustively matched `CommentKind`. New
`HtmlOpen`/`HtmlClose` variants triggered `E0004` during Rust
compilation in the GitHub Actions packaging job.

- **Parser compatibility update**
- Extend comment-kind mapping in `collect_comments` to handle newly
introduced `oxc` variants.
- Map `HtmlOpen` and `HtmlClose` to Ruby-facing `"Line"` comments to
preserve existing comment typing semantics.

- **Regression coverage**
- Add focused parser tests for HTML-style comments to ensure both open
(`<!--`) and close (`-->`, script mode) forms are serialized as line
comments.

```rust
kind: match comment.kind {
  CommentKind::Line => "Line",
  CommentKind::SingleLineBlock | CommentKind::MultiLineBlock => "Block",
  CommentKind::HtmlOpen | CommentKind::HtmlClose => "Line",
},
```

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: marcoroth <6411752+marcoroth@users.noreply.github.com>
@marcoroth
marcoroth marked this pull request as ready for review September 28, 2026 16:12
@marcoroth
marcoroth enabled auto-merge (squash) September 28, 2026 16:13
@marcoroth
marcoroth merged commit cb3ecab into main Sep 28, 2026
11 checks passed
@marcoroth
marcoroth deleted the bot-dep-oxc-0.152.0 branch September 28, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants