build: enable Error Prone and NullAway (JSpecify) with aauth-signing fully @NullMarked - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the Error Prone/NullAway deferral from docs/PROGRESS.md.
jdk.compileradd-exports/add-opens extend the existing.mvn/jvm.config. Findings fixed: locale-safetoLowerCase/splitusage inSignatureBaseandAAuthHeaders;ArrayRecordComponentsuppressed with justification on records that intentionally carry rawbyte[](crypto/HTTP bytes, record equality unused).OnlyNullMarkedmode with JSpecify 1.0.1.aauth-signingis fully@NullMarked: nullable parameters/returns annotated (@Nullableclaim accessors, verifier helpers, exception constructors,JwksFetchercontract), andSignRequest/VerifyRequestbuilders now validate and normalize before constructing their records.Jwkgained arequiredStrhelper so missing required JWK fields raise a clearIllegalArgumentExceptioninstead of an NPE.@NullMarkedtheaauthmodule package by package.200 tests green; coverage gates met.
🤖 Generated with Claude Code