Fix lower amplitude bound: use nearest-edge distance, not nearest vertex#1
Open
tomkoenecke wants to merge 1 commit into
Open
Fix lower amplitude bound: use nearest-edge distance, not nearest vertex#1tomkoenecke wants to merge 1 commit into
tomkoenecke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Marco,
I noticed in
compute_amplitude_bounds_givenfrequency: when the origin isoutside the convex hull, the lower amplitude bound used the nearest hull vertex
(
abs(convhull[ch_min])), but the true minimum |z| is the distance to the nearestedge. So the lower bound could sit a bit too high.
For larger FFTs the gap is negligible, it only really shows up with few / very uneven inputs.