Add Immersive Canvas toggle to fit image above the floating toolbar - #772
Merged
Merged
Conversation
When disabled, fit-to-window reserves space for the toolbar pill so the image is never occluded. The setting persists across sessions and is accessible from the overflow menu and the shortcut editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The floating action toolbar sits over the bottom of the canvas. On portrait-orientation frames the pill can land on the image itself rather than just below it — how much depends on screen size/resolution — which is distracting when judging composition.
Immersive Canvas (toolbar overflow ⋯ menu, checkable) controls this:
Kept as an opt-in toggle rather than a default change, since maximizing screen usage by overlapping the toolbar is presumably a deliberate choice for some setups/screens too, not just an oversight — this just gives people who find it distracting a way out without taking that away from anyone else. Worth keeping in mind if a floating-toolbar rework is ever on the table.
The setting persists across restarts and has a bindable (currently unassigned) shortcut via the shortcut editor.
Test plan
make all(3421 passed, 1 pre-existing unrelatedtest_overflow_bar.pyfailure — confirmed failing identically onmainbefore this change)