Repository navigation
V2/repo glue - #10
Merged
Merged
V2/repo glue#10
Conversation
Vitest 5 writes them to .vitest/attachments/, which .vitest-attachments/ didn't match, so 26 screenshots from engine test runs were committed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing loaded it, and oxlint's react plugin already runs the same rules, React Compiler ones included (react/hooks, exhaustive-deps, purity, refs, immutability, set-state-in-render). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The e2e test listed the pages by hand and skipped the 404 page. PAGES now lives in pages.ts, which vite.config.ts builds from and the test loops over, so a new page is checked once it's built. A path that doesn't exist gets the 404 page through not_found_handling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
apps/web had no tests and ran Vitest with --passWithNoTests. It now runs them in Node with the app's own Vite config: - classify(), by the files' headers and never their names - checkSafety(), against the security.json this repo deploys, too - errorMessage() - _headers requires Trusted Types and allows exactly the policies trusted-types.ts creates - wrangler.example.jsonc serves the folder Vite builds into CI runs them in the check job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pnpm check runs format check, lint, typecheck, Knip and every package's tests: what to run before calling a change done. CI runs Knip in the check job. What Knip found on the first run: - the engine's direct @vitest/browser, which vitest/browser reaches through @vitest/browser-playwright - exports used only in their own file, now unexported, and SNIFF_SIZE and SinkKind, which nothing used - styles.css and with it tailwindcss, since Knip doesn't follow the pages' <link rel=stylesheet>: an entry in knip.jsonc, with why devEngines makes pnpm refuse a Node older than 24 instead of warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The commands and the environment variables they take, what to run before calling a change done, the workspace's rules, and the test conventions. The engine's and the app's write down the rules that lived only in lint config, package exports and comments: the engine's two entry points, byte-identity with typage, sw-stream.ts's APIs, the seams tests use instead of mocks, the CSP and Trusted Types, the pages and security.json. Claude Code reads AGENTS.md itself when there's no CLAUDE.md, so there is none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.