Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something that's been bugging me for ages is that I can't resize the instruction widget. Or, more specifically, I can edit the layout and make the widget bigger, but loading another task will reset it back to the default size.
I finally figured out why this was happening and fixed it. Turns out we just needed to delete some code. I think this code was intended to remember whether the widget is collapsed between page loads, but that didn't seem to work reliably either and is a dubious feature in my opinion, so I just removed it altogether.
I also made the instructions widget taller by default (which I think will only affect new users? or maybe it will affect everyone who has never edited their layout? unclear).
I'm glad that v4 is doing away with the configurable widgets model for the task completion screen, because it's a headache to maintain. But in the mean time this will fix one of the most grating bugs.