Move Memos onto the shared card layer (plan PR 4) - #97
Merged
Conversation
PR 4 of the UI component-system plan (docs/ui-component-system-plan.md). - ReminderCard rewritten as a thin binding onto DashListCard. Overdue Memos drop the reserved errorContainer/error palette and map through statusTone to the shared overdue vocabulary (red accent bar + red time). The opaque container plus PR 3's swipe-panel gating fix the archived-overdue Memo that showed a coloured panel and stray label through the card. - SourceChip: a colour-coded chip naming each alarm's origin, tinted from LocalTypeAccents (green chore-sourced, lavender task-sourced), replacing the plain primary-coloured linked label. The text carries the meaning; colour is a secondary cue. Ad hoc Memos have no source and show no chip, as before. - Memos leaves the owner/zen/sort/filter slots empty (it is a collation surface, §5c). - ChoreOverviewSheet and TaskOverviewSheet adopt the shared CategoryBadge and OwnerAvatar so the detail views match the list views. - DashListCard content slot regains the 4dp inter-line gap (lost when the cards moved onto the shell in PR 2); needed by Memos and restores the Task title/meta spacing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011bvGtNaiY6zFyB2w4fTVAf
mapgie
changed the base branch from
claude/list-scaffolding-identity-strip
to
claude/pr-94-review-zm6ost
August 22, 2026 09:20
PR 5 of the UI component-system plan (docs/ui-component-system-plan.md). - ui/components/core/Gallery.kt: a set of @Preview composables rendering the three card bindings and every core primitive side by side, in light/dark, zen, and high-contrast. The Storybook analogue: one place to see drift in review. Preview-only; nothing ships in the running app. - ui/components/README.md: documents the rule the layer exists to enforce - screens compose components, screens do not draw - plus the layout, the opaque-container and one-status-vocabulary rules, and how to add a component. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011bvGtNaiY6zFyB2w4fTVAf
mapgie
marked this pull request as ready for review
August 22, 2026 09:36
Component gallery + components guide (plan PR 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements PR 4 of the UI component-system plan (
docs/ui-component-system-plan.md, from #94). Stacked onclaude/list-scaffolding-identity-strip(PR 3); the diff here is PR 4 only. GitHub retargets tomainas the stack merges down.Changes
ReminderCard→DashListCard. Overdue Memos drop the reservederrorContainer/errorpalette (whichCLAUDE.mdreserves for genuine errors) and map throughstatusTone()to the shared overdue vocabulary: a red accent bar and red time text. The opaque container, plus PR 3's swipe-panel gating, fully fix the archived-overdue Memo that rendered as a purple card with a red rim and a "Done✔" label showing through.SourceChip(new) — a colour-coded pill naming each alarm's origin, tinted fromLocalTypeAccents(green for chore-sourced, lavender for task-sourced), replacing the plain primary-coloured linked label. The label text ("Chore: Air Plant") carries the meaning; colour is a secondary cue. Ad hoc Memos have no linked source and show no chip (unchanged from today's behaviour).ChoreOverviewSheet,TaskOverviewSheet) adopt the sharedCategoryBadgeandOwnerAvatar, so the detail views match the list views (they previously showed an uppercase text eyebrow and no owner).DashListCardcontent slot regains a 4dp inter-line gap that was lost when the cards moved onto the shell in PR 2 — needed by Memos and restoring the Task title/meta spacing.Checks
python3 a11y_check.py— clean (88 files).memos-shared-layer.json(patch).🤖 Generated with Claude Code
https://claude.ai/code/session_011bvGtNaiY6zFyB2w4fTVAf
Generated by Claude Code