Phase 8: unified day log becomes the only logging surface, superseded screens removed

[mapgie]

Phase 8: cleanup and removal (final phase of the logging redesign)

Gated on the owner's parity sign-off (recorded 2026-08-28 in PLAN.md section 7). Every removal below is matched to a proven replacement; PLAN.md section 3 is the contract and is walked in full at the end.

Prerequisites #185 and #186 were already merged to main (v0.57.0-beta.1), so this branch is cut straight from main and the diff contains only Phase 8 work.

What changed

1. Entry points flipped to log_day

• Calendar day tap (quick log): period quick log opens the day screen (it resolves start/continue/edit itself); a category quick log opens the day screen with that category focused via the new categoryId argument; instant Plus One increments are unchanged.
• Speed dial: "Log Period" and every category item open the day screen for the targeted date (categories focused).
• Day sheet: the former "Try the new day log (preview)" row is now the standard "Open day log" action; "Period" edit opens the day screen for that day; a tracked entry's edit opens the day screen targeting that exact log; "Log more for this day…" still opens the full menu.
• Quick Log widget deep link: opens today's day screen with the tapped category focused. Widget rendering untouched; the PIN-lock neutral-placeholder invariant holds unchanged (GoFloWidget.kt not in this diff).
• Period detail (Period detail screen: view one period day by day #186): the top-bar pencil now opens the day screen on the episode's first day ("Open first day"), replacing its Screen.LogPeriod.withId reference.

2. Parity gap closed before deletion (Phase 5 deviation)

Editing one specific same-day log of an allowMultiple category previously still routed to LogCategory. log_day now accepts logId: LogViewModel loads that one log as its category's entry with existingLog set, so Save goes through updateLogInPlace and "Delete entry" removes exactly that log. The day sheet's per-entry edit uses it. The deep links are one-shot (consumed on first load); switching day reloads normally.

3. Removed (each verified reference-free by grep before and after)

• LogPeriodScreen.kt + LogPeriodViewModel.kt (incl. PinnedCategoryInput, SectionLabel, its private DatePickerDialogWrapper)
• LogCategoryScreen.kt + LogCategoryViewModel.kt (incl. DateSelectorCard, its private DatePickerDialogWrapper)
• LogEntryTopBar.kt (orphaned once both callers were gone)
• Routes Screen.LogPeriod, Screen.LogCategory and their MainActivity registrations and imports
• AddCategoryDialog, EditAppearanceDialog, RenameCategoryDialog (superseded since Phase 7, annotated @Suppress("unused")) and their orphaned helpers CategoryColorPicker, CategoryIconGrid, NumericSettingsSection
• Dead ViewModel methods: ManageCategoriesViewModel.addCategory/.updateCategoryAppearance; ManageCategoryValuesViewModel.renameCategory/.updateAppearance/.updateNumericSettings/.updateUnit/.setShowInLogPeriod/.setAllowMultiple/.setTrackAgainstTime

4. Relocated / consolidated (not removed)

• metricConfigFor + TimedIncrementTimeline moved to ui/screens/log/MetricSupport.kt (LogScreen consumes them)
• DatePickerDialogWrapper consolidated into one shared ui/components/DatePickerDialogWrapper.kt
• FullColorPickerDialog + SaturationValuePanel/HueSlider + isFixedColorToken/isCustomColorToken moved to ui/screens/categories/CategoryColorPickerDialog.kt (still used by CategoryEditScreen's custom colour slot and the adopt-colour rules)
• ManageCategoryValuesScreen: per-type settings sections that duplicated the edit flow (slider range/step labels/decimals/unit, free-numeric unit, and the log-with-period / allow-multiple / track-against-time switches) are consolidated into the Edit action, which provably covers each (CategoryEditScreen step 2 + unit field + Options card, incl. system Flow in slider mode). The screen keeps what only it does: value catalog CRUD, the built-in Flow chips/slider switch, the alarms section, archive/delete, and now points at Edit for the rest.

5. Kept deliberately

PeriodDaySync (flow mapping + the save fan-out syncFlowToTrackingLog/syncSymptomsToTrackingLog/computePinnedValues; also used by PeriodDetailViewModel), AddSymptomDialog, widget + reminder refresh on save, SelectableChip, all repository methods (a few setters, e.g. updateNumericSettings, now have no UI caller but stay as data-layer API per the phase guide's do-not-remove rule), CustomAlarm system, tracking modes, quick-log, export, Stats/History.

PLAN.md section 3 preservation walk (verified by inspection on the finished tree)

Logging

• Generic category value, all input types: LogScreen renders every category through MetricInput (CategoryMetricSection/MetricSectionBody); chips (default), stepped scale/slider (numeric_slider), free numeric with unit (numeric_free), count stepper (increment), timed increment with per-tap timestamp + timeline (TimedIncrementTimeline in MetricSupport.kt, per-tap saves in LogViewModel.addTimedIncrement).
• "Previously recorded (removed from options)" chips: LogScreen.MetricSectionBody (default type).
• Notes per log (500-char cap): per-entry "Add note" field in MetricSectionBody. Edit an existing log: non-allowMultiple entries load automatically; a specific allowMultiple log via the logId deep link. Delete a log: "Delete entry" with confirmation. Date selection: title sheet "Change day" + Day card (replaces canEditDate; a logId targeting is dropped on day switch, matching the old screen's fixed-date rule for by-id edits).
• Period day: start/end dates (PeriodDatesSection), ongoing null end ("Still ongoing", "Clear end date"), flow slider or chips with the 1→Spotting/2→Light/4→Heavy/else Medium mapping (FlowSection + PeriodDaySync), symptoms chips + inline Add via AddSymptomDialog writing to the value catalog (SymptomsSection, addNewSymptomToLibrary), pinned showInLogPeriod categories in the flow context, episode notes.
• Episode/continuation logic: gap tolerance from prefs (LogViewModel.init), episode day number (top bar + Day section), range vs open-ended (logPeriodRange vs logPeriodDay in save()), "Remove this day", "Delete Entire Period", "Disable period logging" (overflow menu).
• Unsaved-changes guard: BackHandler + save/discard dialog on LogScreen (now also guards day switches).
• Period save fan-out: PeriodDaySync.syncFlowToTrackingLog / .syncSymptomsToTrackingLog / .computePinnedValues in LogViewModel.save() (unchanged since Phase 5).
• Side effects on save: GoFloWidget.updateAllWidgets + ReminderScheduler.refreshPredictionReminders on period saves, day removal, and episode deletion.

Categories & management

• Create / rename / archive / unarchive / delete (system protected) / reorder: CategoryEditScreen (create + rename + delete-with-history), ManageCategoriesScreen swipes + reorder mode, ManageCategoryValuesScreen menu.
• Per-category icon, colour token (roles + fixed hex + custom picker), input type ("fixed once logged"), numeric range/unit/decimals, scale labels, allow-multiple, show-in-log-period, track-against-time, mode key: all on CategoryEditScreen (mode key carried through CategoryEditViewModel.save).
• Value catalog CRUD incl. rename-with-history and seeded-value protection: ManageCategoryValuesScreen (kept).
• System categories (Flow, Symptoms, Ovulation Test preset): untouched (seeding, protection, flow chips/slider switch kept on the values screen).
• Tracking modes: ModesScreen untouched.
• Quick-log config + Quick Log widget: ManageQuickLogScreen untouched; widget increment broadcast unchanged; non-increment taps open the day screen focused.
• ManageCategoryValues screen: kept (value editing); per-type settings consolidated into Edit per section 4 above.

Theme & colour

• No theme, palette, or colour-machinery file changed in this diff (wcag_check.py green).

Other surfaces

• Stats, History, Home, DayLogSheet, Dashboard, export, custom alarms: data model untouched (DB stays v24, no migration); only navigation targets changed.

Needs device pass (new or rerouted behaviour that inspection cannot fully confirm):

• The logId deep link end to end: day sheet edit of one allowMultiple entry, in-place save, targeted delete.
• The categoryId focus behaviour from the widget deep link and speed dial (expanded input inside grouped cards).
• Timed-increment per-entry "edit" rows in the day sheet now land on the day screen's timeline (equivalent capability, different surface).
• General smoke pass over every flipped entry point.

Evidence and checks

• Dead-reference grep over the whole main source set for every deleted symbol and route string (LogPeriodScreen, LogPeriodViewModel, LogCategoryScreen, LogCategoryViewModel, PinnedCategoryInput, LogEntryTopBar, DateSelectorCard, Screen.LogPeriod, Screen.LogCategory, log_period, log_category, AddCategoryDialog, EditAppearanceDialog, RenameCategoryDialog, CategoryIconGrid, NumericSettingsSection, the removed VM methods, newEntryForDate, .editEntry(, withId(): zero hits (the only log_category match is the unrelated DataStore key quick_log_category_id).
• Navigation graph read end to end; MainActivity registers no dead route.
• python3 a11y_check.py: clean. python3 wcag_check.py: clean. Semantics-import sweep over all main-set Kotlin files: clean. Changelog fragment validated by check_changelog_fragment.py against origin/main.
• Docs updated: PLAN.md status + section 7 Phase 8 row (Done, DB 24, parity sign-off date, deviations), subsystem maps 01/02 drift notes marking the removals, LESSONS.md (two transferable lessons), changelog fragment logging-redesign-cleanup.json (minor bump).

🤖 Generated with Claude Code

https://claude.ai/code/session_01PZJLynVBkgLtehJFXffnfg

---

Generated by Claude Code