Phase 4: MetricInput facade + Yes/No and Time input types

[mapgie]

Summary

Phase 4 of the logging redesign (build guide): the MetricInput facade now renders every input type, LogCategoryScreen renders through it instead of its inline per-type when, and two new category input types ship: Yes/No and Time.

Storage (PLAN.md §8 decision #3, resolved by the owner): Yes/No and Time store their readings as plain value-label strings in tracking_log_values: "Yes"/"No" for yes_no, 24-hour "HH:mm" for time. No new DB columns, no migration; DB stays at v24. Documented at the top of MetricInput.kt and in PLAN.md §7/§8.

What changed, by file:

• ui/util/CategoryAppearance.kt: CategoryType gains YES_NO("yes_no", "Yes / No") and TIME("time", "Time"). Persisted keys are stable strings; display names show in the New Category type chips.
• ui/components/MetricInput.kt: full facade. Whole-step rating scales (2 to 10 steps, no decimals) render as StepScale; decimal or wider ranges keep a slider with full parity (whole-number stepped behaviour, large readout, scale label, min/max labels, unset-value hint). numeric_free keeps unit label, placeholder, decimal keyboard. increment counter never drops below 0 and shows the unit. yes_no renders a role-tinted SegmentedToggle; time renders the new TimeField. usesStepScale() is exposed so screens can mirror the variant split.
• ui/components/TimeField.kt (new): tap-to-pick time field opening a Material 24h time picker; Button role semantics, hoisted state.
• ui/screens/log/LogCategoryScreen.kt: the per-type rendering when is gone; every non-timed input renders via one MetricInput call. A small pure mapping (metricValueFor) converts screen state to MetricValue, and the timed-increment path stays screen-driven (per-tap immediate saves, no Save button), now rendering the Timeline primitive with per-entry delete.
• ui/screens/log/LogCategoryViewModel.kt: additive setSelectedValues. Yes/No and Time readings flow through selectedValues as a single-label set, so loading, setDate re-resolution, and the existing else-branch of save() persist them with no new save logic.
• ui/screens/log/LogPeriodScreen.kt + LogPeriodViewModel.kt: PinnedCategoryInput gains additive yes_no/time branches delegating to MetricInput; its four pre-existing branches are untouched, and the new additive setPinnedSingleValue feeds the existing selection-set save path (computePinnedValues else-branch). No restructuring of the period screen.
• data/database/entities/TrackingCategory.kt: isNumeric re-defined from "anything but default" to an explicit list of the numeric types, so yes_no/time chart as label categories in Stats (Yes/No pie/trends work for free) instead of being fed into numeric chart math.
• ui/screens/categories/ManageCategoriesScreen.kt: the New Category dialog picks up the two new types automatically from CategoryType.entries; the unit field is now shown only for the genuinely numeric types.
• Docs: PLAN.md §7 Phase 4 row (Done, DB 24 unchanged, deviations) and §8 Fix Kotlin compile errors blocking CI build #3 marked resolved; subsystem map 01 drift note; LESSONS.md entry; changelog fragment logging-yesno-time-metricinput.json (minor).

Parity walk (map 01 §2, branch by branch)

#	Path	Where it lives now	Stored value
1	numeric_slider	MetricInput NUMERIC_SLIDER: StepScale for whole-step ratings up to 10 steps, parity slider otherwise (same steps formula, readout, scale labels, min/max labels, hint)	unchanged: int or %.1f string; unset still saves numericMin via the untouched VM fallback
2	numeric_free	MetricInput NUMERIC_FREE (unit label, placeholder, decimal keyboard)	unchanged trimmed text; empty still blocks save (VM rule untouched)
3	increment + trackAgainstTime	screen-level TimedIncrementTimeline (count card + Timeline); per-tap immediate save with HH:mm via untouched addTimedIncrement, per-entry delete, no notes/Save	unchanged ("1" per entry + loggedAt)
4	increment untimed	MetricInput INCREMENT counter (floor 0, decrement disabled at 0)	unchanged int string; count <= 0 still blocks save (VM rule untouched)
5	default chips	MetricInput DEFAULT ChipRow; empty-catalog text and "Previously recorded (removed from options)" chips kept at screen level verbatim	unchanged label set
6	yes_no (new)	MetricInput YES_NO SegmentedToggle	"Yes" / "No" value label
7	time (new)	MetricInput TIME TimeField	"HH:mm" value label

Shared extras confirmed intact: notes 500-char cap, Save/Update, delete-with-confirm, DateSelectorCard when canEditDate, edit-vs-new resolution, track-against-time checkbox, pop-back on save/delete.

Acceptance criteria (guide)

• All 7 paths log + edit correctly; stored values identical to main for the 5 existing ones (verified by inspection against the untouched LogCategoryViewModel.save() / repository paths; CI is the build check)
• Yes/No and Time categories can be created via the current create flow and logged
• LogCategoryScreen no longer contains a categoryType when for rendering (it calls MetricInput; the remaining whens are pure state-to-MetricValue mapping and the guide-sanctioned timed-increment screen flow)
• a11y_check.py green (also wcag_check.py: 405 pairs, all passed)
• Builds green in CI

Feature-preservation checklist (guide)

• Every bullet in the parity procedure passes (table above)
• LogPeriodScreen still works; PinnedCategoryInput's existing four branches untouched, new types additive
• Period fan-out (syncFlowToTrackingLog, syncSymptomsToTrackingLog, syncPinnedCategoryLogs) unaffected (no changes to those paths; computePinnedValues untouched)
• Stats/History still read the same value labels (isNumeric change only reroutes the two new types to the label chart family; the four existing types keep their prior classification)

Notes / deviations

• Role colour on the log screens stays colorScheme.primary (the pre-existing accent) rather than the category's own role token; wiring category roles into the log flow is Phase 5's unified screen.
• With StepScale, an untouched rating shows no selected step (previously the slider sat at the minimum) but still saves numericMin, preserving stored-data parity.
• The timed-increment entry rows previously showed a bare en dash for a missing timestamp; they now show "No time" (also removes an en dash from user-facing text).
• Editing a yes_no/time category from Manage Categories still opens the default value-catalog editor (harmless: their inputs ignore the catalog; the create/edit flow is redesigned in Phase 7).

🤖 Generated with Claude Code

https://claude.ai/code/session_01PZJLynVBkgLtehJFXffnfg

---

Generated by Claude Code