Skip to content

Fall back to default renderer when render is not a function - #562

Merged
Xdudu merged 1 commit into
mainfrom
Xdudu/fall-back-to-default-renderer
Oct 15, 2026
Merged

Xdudu merged 1 commit into
mainfrom
Xdudu/fall-back-to-default-renderer

Conversation

@Xdudu

@Xdudu Xdudu commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Non-function render values (e.g. render: undefined) were ignored, leaving the suggestions library's unescaped renderer in place and bypassing #547. They now fall back to the default escaping renderer.

Note: setRenderFunction() with a non-function value now throws if called before the control is added to the map. Before, it did nothing.

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under main heading before merging

@Xdudu Xdudu self-assigned this Oct 14, 2026
@Xdudu
Xdudu requested a review from a team as a code owner October 14, 2026 15:12
@Xdudu
Xdudu requested review from dcoj and removed request for a team October 14, 2026 15:12
@Xdudu
Xdudu merged commit 0b4b423 into main Oct 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants