Incompatibility with Guava 33.4.1+ leads to "NoSuchFieldError: No static field MODULE"

[faenil]

hi :)

First of all, I would like to thank you for your work on this plugin, it is incredibly valuable and appreciated.

I would like to surface an incompatibility I have been noticing for some time, about 1 year:
Adding a dependency on Guava 33.4.1+ leads to test failures on Android 9/10/11.

It appears the failure might be a result of this plugin trying to read the annotations on Guava's classes.

The behaviour is also explained at this issue page
google/truth#1608

Here is a sample stacktrace from the linked issue

> Task :database:connectedDebugAndroidTest
Starting 9 tests on emulator-5554 - 8.0.0
com.google.common.collect.ObjectCountHashMap > initializationError[emulator-5554 - 8.0.0] FAILED 
	java.lang.NoSuchFieldError: No static field MODULE of type Ljava/lang/annotation/ElementType; in class Ljava/lang/annotation/ElementType; or its superclasses (declaration of 'java.lang.annotation.ElementType' appears in /system/framework/core-oj.jar)
	at java.lang.Class.getDeclaredAnnotations(Native Method)
com.google.common.collect.ObjectCountLinkedHashMap > initializationError[emulator-5554 - 8.0.0] FAILED 
	java.lang.NoSuchFieldError: No static field MODULE of type Ljava/lang/annotation/ElementType; in class Ljava/lang/annotation/ElementType; or its superclasses (declaration of 'java.lang.annotation.ElementType' appears in /system/framework/core-oj.jar)
	at java.lang.Class.getDeclaredAnnotations(Native Method)
com.google.common.util.concurrent.ImmediateFuture > initializationError[emulator-5554 - 8.0.0] FAILED 
	java.lang.NoSuchFieldError: No static field MODULE of type Ljava/lang/annotation/ElementType; in class Ljava/lang/annotation/ElementType; or its superclasses (declaration of 'java.lang.annotation.ElementType' appears in /system/framework/core-oj.jar)
	at java.lang.Class.getDeclaredAnnotations(Native Method)
com.google.common.util.concurrent.ListenableFutureTask > initializationError[emulator-5554 - 8.0.0] FAILED 
	java.lang.NoSuchFieldError: No static field MODULE of type Ljava/lang/annotation/ElementType; in class Ljava/lang/annotation/ElementType; or its superclasses (declaration of 'java.lang.annotation.ElementType' appears in /system/framework/core-oj.jar)
	at java.lang.Class.getDeclaredAnnotations(Native Method)
Tests on emulator-5554 - 8.0.0 failed: There was 4 failure(s).
Finished 9 tests on emulator-5554 - 8.0.0
> Task :database:connectedDebugAndroidTest FAILED

Is there any chance you could have a look? :)

[mannodermaus]

Hi, thanks for reporting. I can't reproduce this in the instrumentation sample app just by adding the dependency on Guava, however I can see something similar when adding a Guava annotation on one of the androidTest classes. I guess the codebase needs some form of reference to Guava so that the classloader reaches into it at some point. Not quite the same origin, but at least the error is similar:

+@NullMarked
 class ActivityOneTest {
   // ...
 }

E  Error constructing runner
java.lang.NoSuchFieldError: No static field MODULE of type Ljava/lang/annotation/ElementType; in class Ljava/lang/annotation/ElementType; or its superclasses (declaration of 'java.lang.annotation.ElementType' appears in /system/framework/core-oj.jar)
   	at java.lang.Class.getDeclaredAnnotations(Native Method)
   	at org.junit.platform.commons.util.AnnotationUtils.findAnnotation(AnnotationUtils.java:156)
   	at org.junit.platform.commons.util.AnnotationUtils.findMetaAnnotation(AnnotationUtils.java:198)
   	at org.junit.platform.commons.util.AnnotationUtils.findAnnotation(AnnotationUtils.java:156)
   	at org.junit.platform.commons.util.AnnotationUtils.findAnnotation(AnnotationUtils.java:137)
   	at de.mannodermaus.junit5.internal.runners.AndroidJUnitPlatformTestTree.getSuiteDisplayName(AndroidJUnitPlatformTestTree.kt:92)
   	at de.mannodermaus.junit5.internal.runners.AndroidJUnitPlatformTestTree.generateSuiteDescription(AndroidJUnitPlatformTestTree.kt:86)
   	at de.mannodermaus.junit5.internal.runners.AndroidJUnitPlatformTestTree.<init>(AndroidJUnitPlatformTestTree.kt:36)
   	at de.mannodermaus.junit5.internal.runners.AndroidJUnitFramework.generateTestTree(AndroidJUnitFramework.kt:70)

It should be safe to be very defensive about the annotation lookup, as it's only supposed to find the @SuiteDisplayName of the test class if present, using its class name as a fallback. I'll take a look!

[mannodermaus]

I removed the need to discover annotations via JUnit's APIs, as they weren't really used anyway. Furthermore, the runtime will skip non-test classes passed to it by the Android instrumentation more quickly, which could also mean a slight performance boost. Would you mind trying your failing Guava case against the latest 2.0.2-SNAPSHOT version of the plugin & instrumentation?

[faenil]

I guess the codebase needs some form of reference to Guava so that the classloader reaches into it at some point.

Indeed, that was my feeling too...the error is very likely to have the same underlying cause :)

Would you mind trying your failing Guava case against the latest 2.0.2-SNAPSHOT version of the plugin & instrumentation?

That's very kind of you, thank you so much for working on it so quickly!

I'll give a try over the next couple of days! :) 🙏