Pointer chain checks#311
Open
Krilliac wants to merge 1 commit into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears intended to introduce/support “pointer chain checks” for Warden, but the code changes themselves don’t implement a new Warden check type; instead it adds a contrib SQL seed/example file describing a new check type (244 / 0xF4) plus a small header-include change.
Changes:
- Add a new contrib SQL file (
pointer_chain_examples.sql) with examplewardentable rows for a proposedPOINTER_CHAIN_CHECKtype. - Add an extra standard library include in
WardenWin.h. - No functional logic changes are evident in
WardenWin.cpp/WardenCheckMgr.cppbeyond the diff re-rendering.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/game/Warden/WardenWin.h | Adds a standard header include (currently unused as written). |
| src/game/Warden/WardenWin.cpp | No functional change observed in the shown diff. |
| src/game/Warden/WardenCheckMgr.cpp | No functional change observed in the shown diff; review focused on DB-driven type handling. |
| contrib/warden/pointer_chain_examples.sql | Adds example SQL seeds/documentation for a new proposed Warden check type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
29
to
31
| #include "Warden.h" | ||
| #include <vector> | ||
|
|
Comment on lines
+1
to
+5
| -- ============================================================================ | ||
| -- POINTER_CHAIN_CHECK (type 244 / 0xF4) example seeds for the `warden` table. | ||
| -- | ||
| -- Wire format on the client side is identical to MEM_CHECK (243 / 0xF3); the | ||
| -- server walks a multi-hop pointer dereference chain across consecutive Warden |
Comment on lines
+112
to
+123
| uint16 id = fields[0].GetUInt16(); | ||
| uint16 build = fields[1].GetUInt16(); | ||
| uint8 checkType = fields[2].GetUInt8(); | ||
| std::string data = fields[3].GetString(); | ||
| std::string checkResult = fields[4].GetString(); | ||
| uint32 address = fields[5].GetUInt32(); | ||
| uint8 length = fields[6].GetUInt8(); | ||
| std::string str = fields[7].GetString(); | ||
| std::string comment = fields[8].GetString(); | ||
|
|
||
| WardenCheck* wardenCheck = new WardenCheck(); | ||
| wardenCheck->Type = checkType; |
PR mangoszero#311's branch had diverged from mangoszero/master with an unrelated history that could no longer be merged. Re-base the pointer-chain-check feature (Warden CUSTOM/POINTER_CHAIN_CHECK 244: multi-hop pointer-deref scanning with optional signature-detect invert-match) cleanly onto the current master tip. Squashes the three original feature commits; no upstream history is discarded beyond the stale divergent base. Warden.h enum, WardenWin.{h,cpp} handling, WardenCheckMgr loaders, and the contrib/warden SQL examples are all preserved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GD6LV6acKwGd426dDQGPDF
Krilliac
force-pushed
the
claude/add-custom-pointer-check-XcR4N
branch
from
2fb9aed to
012748e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is