Skip to content

Use working App Store Connect key for notarization - #1340

Merged
malpern merged 1 commit into
masterfrom
fix/notary-default-key
Oct 24, 2026
Merged

malpern merged 1 commit into
masterfrom
fix/notary-default-key

Conversation

@malpern

@malpern malpern commented Oct 24, 2026

Copy link
Copy Markdown
Owner

The saved KeyPath-Profile now returns Apple 401, and the old default API-key file is absent. Prefer the existing 62KY64SQQB App Store Connect key by default so release-candidate works without manual environment overrides. Verified notarytool history with this key, completed a notarized/stapled KeyPath release-candidate deploy from merged master using the same key, and passed release-doctor.sh --release-candidate with the new default.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T15:29:26.550429Z beb7ef7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Oct 24, 2026

Copy link
Copy Markdown

Review: no actionable findings. The change swaps the default App Store Connect notary key ID and key path (XQ4565NYZ7 -> 62KY64SQQB) consistently in Scripts/lib/signing.sh, the release-candidate.sh help text, and release-process.md. The key ID and path are identifiers, not secrets, and the KP_NOTARY_* env overrides still work. One thing to confirm outside the diff: the issuer UUID default is unchanged. If the new key belongs to a different team or issuer, notarization will fail with auth errors, so check that the issuer matches the new key.

@malpern
malpern merged commit ef698e2 into master Oct 24, 2026
6 checks passed
@malpern
malpern deleted the fix/notary-default-key branch October 24, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant