Repository navigation
Preserve Aqua Voice paste shortcuts through KeyPath - #1331
Merged
Merged
Conversation
malpern
force-pushed
the
fix/aqua-synthetic-paste
branch
from
October 22, 2026 05:29
0153925 to
e946ed1
Compare
|
Review: no blocking issues. The bypass is placed correctly. It runs after the Non-blocking notes:
|
malpern
marked this pull request as ready for review
October 22, 2026 05:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aqua Voice dictation could insert a literal
vin ChatGPT while the transcript still appeared in clipboard history. KeyPath's session tap remapped software-generated Cmd+V and rebuilt its flags from physical modifier state, dropping aggregate-only Command. A live AppKit diagnostic on the Air confirmed a Cmd+V sent by the probe arrived as plain V with the KeyPath worker's source PID; the test did not change the clipboard or trigger Aqua Voice Hook.Pass software keyboard events through unchanged before touching modifier, Caps, held-input, or Kanata state. Hardware input remains mapped, and tap-disabled notifications still reach recovery. Includes focused tests and a durable investigation note.
Validation:
Scripts/review-gate.shattempted; local Claude review could not complete because its session quota is exhausted. GitHubclaude-reviewmust pass before merge.