Repository navigation
Admission engine and pack checker are actor-free - #1324
Conversation
Both only read value types and the immutable pack registry, so the @mainactor on AdmissionEngine and PackDependencyChecker bought nothing and forced nonisolated carve-outs for the save gate and the CLI, plus a main-actor annotation on RuleCollectionCatalog.driverlessUnavailableReason. All removed; every caller asks directly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review of PR 1324: no blocking findings. The change drops Two things to confirm. I only had the diff, so I haven't verified either:
No test-coverage gaps stand out, since this is an isolation-only change with no behavior change. |
AdmissionEngineandPackDependencyCheckeronly read value types and the immutablePackRegistry, so their@MainActorbought nothing and forcednonisolatedcarve-outs for the save gate and the CLI, plus a main-actor annotation onRuleCollectionCatalog.driverlessUnavailableReason(and two tests). All removed; every caller asks directly. Doc note added to §4.4h.KEYPATH_TEST_ENFORCE_CLEAN_SUMMARY=1 Scripts/run-tests-safe.sh: 5,776 passed, 0 app warnings/errors, 0 build warnings.🤖 Generated with Claude Code