refactor: migrate web Loader to @makeplane/propel Skeleton - #9766
refactor: migrate web Loader to @makeplane/propel Skeleton#9766codingwolf-at wants to merge 4 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor found 12 new issues in 11 files · 12 warnings · score 80 / 100 (Needs work) · 12 fixed · vs 12 warnings
Reviewed by React Doctor for commit |
be9adeb to
da1a7ab
Compare
Updated various components across the application to use Skeleton and SkeletonItem from @makeplane/propel/components/skeleton instead of Loader for displaying loading states. This change enhances the user experience by providing a more visually appealing loading indication. Components affected include issue details pages, analytics loaders, and various modals.
Updated various components to improve loading state visuals by integrating Skeleton and SkeletonItem from @makeplane/propel/components/skeleton. This change affects issue details pages, analytics loaders, and other UI elements, providing a more cohesive and visually appealing user experience during loading times.
Added translations for loading states in various languages, including Czech, German, English, Spanish, French, Indonesian, Italian, Japanese, Georgian, Korean, Polish, Brazilian Portuguese, Romanian, Russian, and Slovak. This enhancement improves the user experience by providing localized loading messages across the application.
Replaced static aria-labels in various components with localized strings using the translation function. This change enhances accessibility and user experience by providing contextually relevant loading messages across the application. Components affected include issue details, analytics loaders, and various modals.
Description
Replace
@plane/uiLoader/Loader.Iteminapps/webwith@makeplane/propelSkeleton+SkeletonItem.Pulse placeholders now use the design-system primitive (required
aria-label,blockSize/inlineSizeinstead ofheight/width). Layout classes stay on wrappers — Propel Skeleton does not takeclassName. Scope is web only;@plane/uiLoaderis unchanged for space/editor.Depends on unpublished Skeleton in
@makeplane/propel(see Propel PR).apps/webis linked to a local tarball until that ships.Type of Change
Screenshots and Media (if applicable)
Test Scenarios
bg-layer-1.References