refactor(web): migrate LogoSpinner to @makeplane/propel - #9764
refactor(web): migrate LogoSpinner to @makeplane/propel#9764codingwolf-at wants to merge 3 commits into
Conversation
…cross the application * Replaced imports of LogoSpinner from the common component to the new location in @makeplane/propel. * Updated LogoSpinner usage to include size and alt attributes for better accessibility and consistency. * Removed old LogoSpinner GIF assets as they are no longer needed. This change ensures a unified approach to using the LogoSpinner component throughout the application.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor found 4 new issues in 4 files · 4 warnings · score 91 / 100 (Great) · 5 fixed · vs 4 warnings
Reviewed by React Doctor for commit |
codingwolf-at
changed the title
This change aligns the lockfile with the latest version of @makeplane/propel, ensuring consistency across the project dependencies.
…state * Replaced static "Loading" alt text with a translatable string using the `useTranslation` hook across multiple components. * This change enhances accessibility and supports localization for the loading indicator in various parts of the application.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -27,6 +28,8 @@ type NotificationsRootProps = { | |||
| }; | |||
|
|
|||
| export const NotificationsRoot = observer(function NotificationsRoot({ workspaceSlug }: NotificationsRootProps) { | |||
There was a problem hiding this comment.
React Doctor · react-doctor/no-high-complexity-react-function (warning)
NotificationsRoot has cyclomatic complexity 20, cognitive complexity 18, and maximum nesting depth 3, so its React logic is hard to understand and change. Extract independent branches into components or hooks.
Fix → Extract independent render branches and state logic into focused components or hooks until the control flow is easy to follow.
1 participant
Description
Replace the web app's local
LogoSpinner(theme-picked GIFs underapps/web) with@makeplane/propel/components/logo-spinner. Call sites passsize="fluid"andaltso the mark is accessible and matches the old splash heights (24px → 44px atsm).Hydrate fallback no longer waits on
next-themes: Propel renders both theme GIFs and CSS selects viadata-theme, which removes the blank canvas before the mark. Workspace auth only shows the spinner on first load when workspace info is missing, so a permissions refetch does not tear down the home dashboard. Vite SSRnoExternals@makeplane/propelso the GIF imports resolve in the prerendered shell instead of 500ing in Node.Type of Change
Screenshots and Media (if applicable)
Screen.Recording.2026-09-04.at.7.17.55.PM.mov
Test Scenarios
bg-canvaswith no empty frame, then the app appears.pnpm --filter=web buildcompletes; the prerendered shell does not 500 on GIF imports.