Skip to content

fix: this pnpm workspace configuration does not set ... in...#9437

Open
anupamme wants to merge 1 commit into
makeplane:previewfrom
anupamme:fix-repo-plane-fix-pnpm-minimum-release-age
Open

fix: this pnpm workspace configuration does not set ... in...#9437
anupamme wants to merge 1 commit into
makeplane:previewfrom
anupamme:fix-repo-plane-fix-pnpm-minimum-release-age

Conversation

@anupamme

@anupamme anupamme commented Jul 19, 2026

Copy link
Copy Markdown

Summary

Address high severity security finding in pnpm-workspace.yaml.

Vulnerability

Field Value
ID package_managers.pnpm.pnpm-missing-minimum-release-age.pnpm-minimum-release-age
Severity HIGH
Scanner semgrep
Rule package_managers.pnpm.pnpm-missing-minimum-release-age.pnpm-minimum-release-age
File pnpm-workspace.yaml:1
Assessment Pattern match — needs manual review

Description: This pnpm workspace configuration does not set a minimum release age. Newly published packages can be malicious or unstable. Add minimumReleaseAge: 10080 (minutes) to wait at least seven days before installing newly published package versions. Added in: v10.16.0 Reference: https://pnpm.io/settings#minimumreleaseage

Evidence

Scanner confirmation: semgrep rule package_managers.pnpm.pnpm-missing-minimum-release-age.pnpm-minimum-release-age matched this pattern as package_managers.pnpm.pnpm-missing-minimum-release-age.pnpm-minimum-release-age.

Production code: This file is in the production codebase, not test-only code.

Threat Model Context

This is a Node.js library - vulnerabilities affect downstream consumers who use this package.

Changes

  • pnpm-workspace.yaml

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

This change addresses a pattern flagged by static analysis. The code path handles user-influenced input and the fix reduces the attack surface against both manual and automated exploitation.


Automated security fix by OrbisAI Security

Summary by CodeRabbit

  • Chores
    • Strengthened dependency update safeguards to prevent untrusted or downgraded package resolutions.
    • Added a minimum release-age policy for newly published dependencies.

…mum-release-age security vulnerability

Automated security fix generated by OrbisAI Security
@CLAassistant

CLAassistant commented Jul 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9bb1cb2c-7b63-4a60-bde5-0c6e6dc010a1

📥 Commits

Reviewing files that changed from the base of the PR and between 7cef741 and 9eec585.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

Adds workspace-level pnpm dependency governance settings for minimum release age, exotic subdependency blocking, and no-downgrade trust policy behavior.

Changes

Dependency governance

Layer / File(s) Summary
Workspace dependency policies
pnpm-workspace.yaml
Adds minimumReleaseAge, blockExoticSubdeps, and trustPolicy settings before the existing exclusion list.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: sriramveeraghanta

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and truncated, so it does not clearly summarize the pnpm minimum-release-age security fix. Use a concise title like "fix: add minimum release age to pnpm workspace".
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the security issue, change, and verification, but it omits the template's Type of Change and References sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants