add sub account deletion - #259
Open
oshchyhol wants to merge 2 commits into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 8, 2026
oshchyhol
marked this pull request as ready for review
September 8, 2026 09:22
mklocek
approved these changes
Sep 8, 2026
oshchyhol
force-pushed
the
MT-23420-dotnet-delete-sub-account
branch
from
September 9, 2026 11:40
ca4fe0b to
2816c77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The organization client can list and create sub accounts but has no way to delete one. This adds the
DELETE /api/organizations/{organization_id}/sub_accounts/{sub_account_id}operation.Changes
IOrganizationSubAccountResourcewithDelete(), reached viaIOrganizationResource.SubAccount(long subAccountId)SubAccount(id)rejects ids less than or equal to zero withArgumentOutOfRangeException, like the other single-resource gettersMailtrap.Example.SubAccountdeletes the sub account it createdHow to test
Use an organization API token with sub account management permissions and a fresh sub account created via
organization.SubAccounts().Create(...).await organizationClient.Organization(orgId).SubAccount(subAccountId).Delete()completes without an exception; the sub account is gone fromSubAccounts().GetAll()Delete()again on the same id –HttpRequestFailedExceptionwith status 404Delete()with a sub account id that belongs to another organization, or with a token that lacks sub account management permissions – status 403Delete()with an invalid token – status 401SubAccount(0)andSubAccount(-1)throwArgumentOutOfRangeExceptionbefore any request is sentdotnet run --project examples/Mailtrap.Example.SubAccountlists, creates and then deletes the demo sub account, loggingDeleted Sub Account: Id=...Companion PRs
Caveat: merge and release only after the backend change ships; the endpoint is not in production yet.