Skip to content

Click spark#975

Closed
R1SH4BH81 wants to merge 13 commits into
magicuidesign:mainfrom
R1SH4BH81:Click-Spark
Closed

Click spark#975
R1SH4BH81 wants to merge 13 commits into
magicuidesign:mainfrom
R1SH4BH81:Click-Spark

Conversation

@R1SH4BH81

Copy link
Copy Markdown

Description

Added new component - ClickSpark

Changes

Added new component - ClickSpark

Motivation

Breaking Changes

none

My last commit was delete by someone , idk why , at least i need a explanation

@vercel

vercel Bot commented May 27, 2026

Copy link
Copy Markdown

@R1SH4BH81 is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Yeom-JinHo Yeom-JinHo self-requested a review June 1, 2026 03:58
@Yeom-JinHo

Copy link
Copy Markdown
Member

Thanks again for the work here, @R1SH4BH81.

I missed this in the previous review, but after taking another look, this appears to be a near-verbatim port of ClickSpark from react-bits by David Haz. The props/defaults, easeFunc, draw math, handleClick, and JSX structure are all essentially identical to the original.

Our preference is to ship original components rather than re-host ones that already exist in another well-known library. For that reason I'm going to close this one. If you'd like to contribute, an original component (or a substantially different take) would be very welcome 🙏

Also, regarding the deleted commit you mentioned: none of your commits were removed. The change that disappeared was the kinetic-text code from #955, which got pulled into your branch through an unclean rebase. Since it has now been merged into main separately, syncing main correctly removed it from this diff as a duplicate.

@Yeom-JinHo Yeom-JinHo closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants