Skip to content

chore: update solana deps to 4.x compatible - #189

Open
bmuddha wants to merge 1 commit into
mainfrom
bmuddha/chore/update-deps
Open

chore: update solana deps to 4.x compatible#189
bmuddha wants to merge 1 commit into
mainfrom
bmuddha/chore/update-deps

Conversation

@bmuddha

@bmuddha bmuddha commented Jul 29, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

the update is required to resolve the validator dependency conflicts.

Summary by CodeRabbit

  • Compatibility
    • Improved support for backward-compatible builds through an optional compatibility setting.
  • Encryption & Decryption
    • Updated keypair handling for encryption and decryption workflows.
    • Existing encryption, decryption, and delegation behavior remains unchanged.
  • Maintenance
    • Updated underlying blockchain integration components and refined optional feature configuration.

@bmuddha
bmuddha requested review from GabrielePicco and snawaz July 29, 2026 10:07
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2d6e69cd-a33b-492e-9fcc-7d0d202afceb

📥 Commits

Reviewing files that changed from the base of the PR and between dcd46dc and 7cdc2ee.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • dlp-api/Cargo.toml
  • dlp-api/src/compat.rs
  • dlp-api/src/decrypt.rs
  • dlp-api/src/encryption/mod.rs
  • dlp-api/src/instruction_builder/delegate_with_actions.rs
📝 Walkthrough

Walkthrough

Updated crate features and dependencies to replace solana-sdk with optional keypair and signer crates. Backward-compatibility modules and implementations are conditionally compiled. Decryption and encryption keypair APIs, imports, and related tests now use the newer Solana keypair and signer types.

Suggested reviewers: snawaz, gabrielepicco

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bmuddha/chore/update-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

snawaz
snawaz approved these changes Jul 29, 2026
View reviewed changes

@snawaz snawaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread dlp-api/Cargo.toml
Comment on lines -17 to +26
# Offchain encryption/decryption helpers (libsodium + solana-sdk)
encryption = ["dep:libsodium-rs", "dep:solana-sdk"]
diff = []
unit_test_config = []
# Offchain encryption/decryption helpers.
backward-compat = ["dep:borsh-compat", "dep:solana-pubkey-compat"]
cpi = []
diff = []
encryption = ["dep:libsodium-rs", "dep:solana-keypair", "dep:solana-signer"]
instruction = []
backward-compat = []
unit_test_config = []
# Default to offchain-friendly build
default = ["encryption", "diff", "cpi", "instruction"]
default = ["cpi", "diff", "encryption", "instruction"]

@snawaz snawaz Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is one-single-line change here. Other changes are caused by reordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snawaz snawaz snawaz approved these changes
@GabrielePicco GabrielePicco Awaiting requested review from GabrielePicco

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmuddha @snawaz