Use impl instead of ProtocolObject where possible - #517
Open
madsmtm wants to merge 2 commits into
Open
Conversation
madsmtm
added
enhancement
madsmtm
force-pushed
the
protocol-fixes
branch
6 times, most recently
from
December 3, 2023 08:11
2b57f62 to
1c663ba
Compare
madsmtm
force-pushed
the
minimize-use-of-protocolobject
branch
from
November 25, 2024 15:25
392f711 to
3449797
Compare
MarijnS95
reviewed
Sep 17, 2025
Comment on lines
-79
to
-80
| let object = ProtocolObject::from_ref(&*delegate); | ||
| app.setDelegate(Some(object)); |
Contributor
There was a problem hiding this comment.
Ah, I've never used ::from_ref() for these before but always just object = delegate.as_ref() which is a bit more concise and also seemed to figure out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon #516.
We now use
&(impl MyProtocol + Message)instead of&ProtocolObject<dyn MyProtocol>as parameters to functions, this allows users to pass in their objects to these functions much more easily.I'm not sure it's worth the tradeoff in code size though (since now a lot of methods are generic where they don't really have to be), will have to think about.
Alternative to #686 (that one is still strictly cleaner, but probably also not really possible in current Rust (?)).