Skip to content

feat: larger text and higher contrast in the call windows - #3

Merged
macx merged 1 commit into
mainfrom
feat/readable-call-windows
Oct 23, 2026
Merged

macx merged 1 commit into
mainfrom
feat/readable-call-windows

Conversation

@macx

@macx macx commented Oct 23, 2026

Copy link
Copy Markdown
Owner

What and why

Accessibility review follow-up (non-critical findings): larger text in the call windows and enough contrast for warnings and the green/orange circles.

  • Larger text: caller name .headline (13 pt) → .title3 semibold (15 pt) on up to two lines instead of one truncated line; status, timer and ended text .subheadline (11 pt) → .body (13 pt); "Call audio is on …", call waiting and notices .caption (10 pt) → .callout (12 pt); round button captions .caption → .subheadline. Same for the incoming-call banner.
  • Contrast of text (WCAG 1.4.3): orange or red text was about 2:1 (orange) and 3.2:1 (red) on light backgrounds. New StatusMessage view: a warning/error symbol carries the meaning, the text stays in the primary label color. Used in the HUD, banner, popover, Settings, the shortcut recorder and the tel: confirmation.
  • Contrast of symbols (WCAG 1.4.11): white symbols on system green/orange were about 2:1. Accept, the keypad call button and the call row now use Apple's increased-contrast green (#248A3D, 4.4:1), the service-code row its orange (#C93400, 5.3:1). End Call / Decline stay system red (3.4–3.55:1, like FaceTime).

How it was tested

  • scripts/verify.sh --quick passes (build, lint, localization, unit tests, security checks)
  • New or changed behaviour has a test (ColorContrastTests: white on the new colors ≥ 3:1)
  • UI changes: the maintainer should run scripts/verify.sh (UI tests include the German long-name and overlap checks) and look at banner, HUD and popover in English and German, light and dark
  • Bluetooth changes: none

Checklist

  • Every new user-facing string is in App/Resources/Localizable.xcstrings with a German translation and a translator comment (no new strings)
  • No real phone numbers, names, Bluetooth addresses or secrets in code, tests, logs or screenshots
  • No network access, no new third-party runtime dependency
  • Signing, entitlements, release scripts and workflows are unchanged

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings October 23, 2026 09:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Full macOS UI tests and English/German visual checks in light and dark appearances remain pending to validate layout and rendered contrast.

No open issues 🎉

What changed in this PR

This PR improves readability and contrast across Pickup’s call windows and related warnings without changing call-control behavior.

Changes:

  • Enlarges call text and button captions, allowing caller names to wrap onto two lines.
  • Introduces shared warning/error labels with primary-color text and darker green/orange control backgrounds.
  • Adds tests checking white-symbol contrast against the new colors.
File Description
App/​Tests/​PickupAppTests/​ColorContrastTests.swift Tests the new colors against the 3:1 symbol-contrast threshold.
App/​Sources/​Pickup/​ShortcutRecorder.swift Uses shared status labels for shortcut warnings and errors.
App/​Sources/​Pickup/​SettingsView.swift Uses shared status labels for errors.
App/​Sources/​Pickup/​LinkCallConfirmation.swift Updates service-code warning styling and error labels.
App/​Sources/​Pickup/​IncomingCallBannerView.swift Enlarges text, wraps caller names, and updates notices.
App/​Sources/​Pickup/​DialerView.swift Updates notices, errors, and call/service-code colors.
App/​Sources/​Pickup/​CallViewComponents.swift Defines contrast colors and status labels; enlarges control captions.
App/​Sources/​Pickup/​CallHUDView.swift Enlarges caller and status text and updates notices.

Review effort: Balanced

Caller name 15 pt semibold on up to two lines, status and timer 13 pt, hints 12 pt, button captions 11 pt. Warnings and errors keep the text in the label color and carry the meaning in a symbol (orange or red text was about 2:1 to 3.2:1 on light backgrounds). Accept and call circles use Apple's increased-contrast green, the service-code row its orange, so white symbols reach at least 3:1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@macx
macx force-pushed the feat/readable-call-windows branch from 300e66c to 3b7b2f5 Compare October 23, 2026 10:34
@macx
macx merged commit 701dd2c into main Oct 23, 2026
9 checks passed
@macx
macx deleted the feat/readable-call-windows branch October 23, 2026 10:46
macx added a commit that referenced this pull request Oct 23, 2026
## What and why

Hanging up felt unresponsive and then confusing: the phone confirms the
hang-up after one or two seconds, during which End Call showed nothing,
and afterwards the HUD switched to an "ended"/"cancelled" state with a
Close button.

- **Progress:** after End Call, the button shows a spinner and "Ending…"
("Wird beendet …") and is disabled until the phone ends the call. If the
command fails (notice as before) or the phone has not ended the call
within 10 s, the button is usable again.
- **No second state:** a call hung up or cancelled on this Mac closes
the HUD as soon as the phone confirms. Calls ended by the other side,
busy/unanswered, failed or with a lost link still show the ended state
with the reason, since the user did not cause them.

## How it was tested

- [x] `scripts/verify.sh --quick` passes (build, lint, localization,
unit tests, security checks)
- [x] New or changed behaviour has a test (`EndedCallPresentationTests`;
UI scenario tests for hang-up and cancel now expect the HUD to close
without an ended state; compiled, not run here)
- [ ] UI changes: one new string (en/de); the maintainer should run
`scripts/verify.sh` (UI tests) and check the spinner in light/dark and
German
- [ ] Bluetooth changes: none in the protocol; **needs hardware test**:
hang up a real call and check spinner, then the HUD closing

## Checklist

- [x] Every new user-facing string is in
`App/Resources/Localizable.xcstrings` with a German translation and a
translator comment
- [x] No real phone numbers, names, Bluetooth addresses or secrets in
code, tests, logs or screenshots
- [x] No network access, no new third-party runtime dependency
- [x] Signing, entitlements, release scripts and workflows are unchanged

Overlaps with #2 (End Call button) and #3 (call window components);
whichever merges later needs a small rebase.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@macx macx mentioned this pull request Oct 23, 2026
4 tasks done
macx added a commit that referenced this pull request Oct 23, 2026
Release **v0.2.0**, prepared by the prepare-release workflow from main
at `cd9119c`.


### Features

* focus the call panel from the menu bar; Return ends a focused call
([#2](#2))
([61068ee](61068ee))
* larger text and higher contrast in the call windows
([#3](#3))
([701dd2c](701dd2c))
* show progress while hanging up and close the HUD afterwards
([#4](#4))
([780e8a6](780e8a6))

### Before merging (squash merge, keep the title)
- [x] CI is green on this pull request
- [x] Local gate with UI tests on this branch: `scripts/verify.sh`
- [x] Hardware smoke test with the phone if Bluetooth code changed
- [x] No other pull request was merged into main since this one was
prepared (otherwise re-run prepare-release)

Merging starts release.yml: tag v0.2.0, build, GitHub Release
(pre-release).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants