feat: Unified binary (CLI)#252
Draft
Charlotte-Knight wants to merge 7 commits into
Draft
Conversation
|
This is your first PR, thank you for contributing to MaCh3! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User interface
This PR adds the
MCMCTutorialexecutable to the unified CLI introduced in MaCh3 core by this PR: mach3-software/MaCh3#917.This executable is now accessed via the
tutorialsubcommand, like:Upon running
mach3 tutorial --help, you get:and you can identify the
--overrideoption which allows users to override config yaml as before, e.g.and we have added a special option for the number of MCMC steps, so you could instead write:
The advantage of having options like
--MCMCStepsis that they are visible upon callingmach3 tutorial --helpso we recommend implementing options like this for the configurables that are most often changed. For the sake of the tutorial, we may also want to add--outputfile, for example.When overriding the config, the usual standard output like this:
is shown, regardless of whether you use
--MCMCStepsor--override.Future Plans
We may also want to update the tutorial README with this PR, but this depends on how we want to introduce the CLI. Until we have all of the executables implemented, I suggest making a small mention that the CLI exists, e.g. in a block like
Tip
A MaCh3 CLI is in development, you can try it already by running this command with
mach3 tutorial ...instead. Please provide feedback etc...Implementation
TODO
Deprecation warning for
MCMCTutorialstill needs to be added.