Skip to content

chore: remove unused IntelliJ run configs - #969

Open
nickolas-dimitrakas wants to merge 1 commit into
mainfrom
chore/remove-unused-intellij-run-configs
Open

nickolas-dimitrakas wants to merge 1 commit into
mainfrom
chore/remove-unused-intellij-run-configs

Conversation

@nickolas-dimitrakas

Copy link
Copy Markdown
Contributor

Why

The repository still carries four IntelliJ run configurations that no build, test or release step uses. They point readers at local run setups the project no longer maintains. Once this lands, those stale files are gone.

Programme

Standalone change, no programme.

What changes

Before: the repository has a .run/ folder with four IntelliJ run configurations (Full Test and Lint, Lint, Test and Verify kits). After: the folder is gone. Nothing in the repository reads or references it, so no source, build, test or release file changes. The changelog is not edited, because nothing that ships changes.

Linked work

None.

Rollout

Nothing changes in production; if this is wrong, revert the pull request.

Risks

  • Someone still uses one of the run configurations in their IDE; nothing in the repository references them; we would see a question on this pull request or an issue.

Risk: low.

Who

Written by: an automated coding agent, at a maintainer's request.
Code reviewed before opening: no one.
Design reviewed before opening: no one.
Decision this implements: a maintainer's request to remove unused tooling configuration.
Checked: a search of the repository for references to the .run/ folder, outside the files themselves, found none.
Not checked: an IDE or Gradle run, since no build input changes.

Size

Hand-written: 100 lines removed in 4 files.
Generated: none

@nickolas-dimitrakas
nickolas-dimitrakas requested a review from a team as a code owner October 22, 2026 15:12
@github-actions

Copy link
Copy Markdown

Kotlin migration progress

No change to the Java left to convert.

Module Kotlin LOC Java LOC Java staying (facade) Java left to convert Kotlin share
android-core 3,249 22,690 9,716 12,974 12.5%
android-kit-base 601 5,405 1,651 3,754 10.0%
Total 3,850 28,095 11,367 16,728 12.1%

Conversion progress: 0.0% (16,728 of 16,550 baseline Java LOC left to convert). 132 Java files and 36 Kotlin files in scope.

@github-actions

Copy link
Copy Markdown

Binary compatibility

  • ✅ android-core is compatible with 6.1.9 (115 classes compared, 0 with additions only).
  • ✅ android-kit-base is compatible with 6.1.9 (44 classes compared, 0 with additions only).

Compares the release AAR against the same artifact at the last version published to Maven Central; R8-renamed classes and members are excluded (see the script docstring). Full japicmp HTML/XML reports are attached as the api-compat-reports workflow artifact. This check is not in the required-check set yet, so a red result here does not block merging.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@github-actions

Copy link
Copy Markdown

📦 SDK Size Impact Report

What the SDK adds to a minified release APK.

mParticle Core SDK

Measured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.

Metric Target branch This PR Change
APK size 120.63 KB 120.63 KB +1 bytes
Download size 118.45 KB 118.45 KB -3 bytes
Dex bytes 215.25 KB 215.25 KB 0 bytes

mParticle Core + Rokt kit

Measured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see size-report-rokt/README.md.

Metric Target branch This PR Change
APK size 1.26 MB 1.26 MB 0 bytes
Download size 1.25 MB 1.25 MB -2 bytes
Dex bytes 2.23 MB 2.23 MB 0 bytes

Rokt SDK+ umbrella (adds the payment extension)

Metric Target branch This PR Change On top of mParticle Core + Rokt kit
APK size 6.55 MB 6.55 MB 0 bytes +5.29 MB
Download size 6.43 MB 6.43 MB -1 bytes +5.19 MB
Dex bytes 7.12 MB 7.12 MB 0 bytes +4.88 MB

➡️ SDK size impact change is minimal.

Raw measurements

core, Target branch:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2510, "baseline_install_bytes": 7527, "core_dex_bytes": 220412, "core_download_bytes": 123805, "core_install_bytes": 131055}

core, This PR:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2512, "baseline_install_bytes": 7528, "core_dex_bytes": 220412, "core_download_bytes": 123804, "core_install_bytes": 131057}

rokt, Target branch:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4170020, "kit_download_bytes": 2548125, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9291568, "sdkplus_download_bytes": 7985699, "sdkplus_install_bytes": 8165359}

rokt, This PR:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4170020, "kit_download_bytes": 2548123, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9291568, "sdkplus_download_bytes": 7985698, "sdkplus_install_bytes": 8165359}

Measured dd8e09f merged into b7624a5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants