Repository navigation
chore: bump org.jetbrains.kotlin:kotlin-stdlib-jdk7 in /kits/adobemedia/adobemedia-3 - #965
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [org.jetbrains.kotlin:kotlin-stdlib-jdk7](https://github.com/JetBrains/kotlin) in `/kits/adobemedia/adobemedia-3` from 2.1.20 to 2.1.21. Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk7` from 2.1.20 to 2.1.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.1.20...v2.1.21) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-stdlib-jdk7 dependency-version: 2.1.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gradle ... Signed-off-by: dependabot[bot] <support@github.com>
Kotlin migration progressNo change to the Java left to convert.
Conversion progress: 0.0% (16,728 of 16,550 baseline Java LOC left to convert). 132 Java files and 36 Kotlin files in scope. |
Binary compatibility
Compares the release AAR against the same artifact at the last version published to Maven Central; R8-renamed classes and members are excluded (see the script docstring). Full japicmp HTML/XML reports are attached as the |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. It's a patch-level Kotlin bump, but CODEOWNERS covers this path, so a human from the owning team should still sign off.
What was reviewed:
- The single change in kits/adobemedia/adobemedia-3/build.gradle:
kotlin_versiongoes from 2.1.20 to 2.1.21. That variable only drives the kotlin-gradle-plugin buildscript classpath. - Version consistency: the root build.gradle and the other 22 kits all pin 2.1.20, so this kit would be the only one on 2.1.21. Inside the aggregate kit build (settings-kits.gradle), the root's 2.1.20 plugin is loaded first and is likely what this kit actually gets there. The bump would only take full effect when the kit builds on its own.
Extended reasoning...
The change is one line: it bumps the Kotlin Gradle plugin version in the Adobe Media kit's buildscript from 2.1.20 to 2.1.21. It touches no security-sensitive code and no runtime SDK logic. Approval was ruled out because CODEOWNERS assigns all paths to an owning team. The bump also leaves this kit out of step with the root build and every other kit, which all stay on 2.1.20.
📦 SDK Size Impact ReportWhat the SDK adds to a minified release APK. mParticle Core SDKMeasured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.
mParticle Core + Rokt kitMeasured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see
Rokt SDK+ umbrella (adds the payment extension)
➡️ SDK size impact change is minimal. Raw measurementscore, Target branch: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2510, "baseline_install_bytes": 7527, "core_dex_bytes": 220412, "core_download_bytes": 123805, "core_install_bytes": 131055}core, This PR: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2511, "baseline_install_bytes": 7528, "core_dex_bytes": 220412, "core_download_bytes": 123797, "core_install_bytes": 131047}rokt, Target branch: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4170020, "kit_download_bytes": 2548125, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9291568, "sdkplus_download_bytes": 7985699, "sdkplus_install_bytes": 8165359}rokt, This PR: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4170020, "kit_download_bytes": 2548120, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9291568, "sdkplus_download_bytes": 7985701, "sdkplus_install_bytes": 8165359} |
|
Looks like org.jetbrains.kotlin:kotlin-stdlib-jdk7 is no longer updatable, so this is no longer needed. |
Bumps org.jetbrains.kotlin:kotlin-stdlib-jdk7 in
/kits/adobemedia/adobemedia-3from 2.1.20 to 2.1.21.Updates
org.jetbrains.kotlin:kotlin-stdlib-jdk7from 2.1.20 to 2.1.21Release notes
Sourced from org.jetbrains.kotlin:kotlin-stdlib-jdk7's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin:kotlin-stdlib-jdk7's changelog.
... (truncated)
Commits
f59375aAdd ChangeLog for 2.1.21-RC2301186f[Gradle] Fix passing process environment when launching KotlinKarma tests12b4021Add changelog for 2.1.21-RCe16f5a8[IC] Update inline function snapshotting5f12d8b[Cherry-picks] Update BTA specific parts for the release branchf025799[IC] Additional test cases for inline function snapshotting58df05e[Tests] More tests for inline fun abi snapshotting9512893[KGP] Experimental: support incremental changes in inlined local classes950cee5[IC] Additional test cases for inlined lambda snapshottinga0a8ca0[BTA Tests] Fix changedSources tracking when compilation fail is expectedDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions