Skip to content

chore: remove unused Phabricator config - #955

Merged
nickolas-dimitrakas merged 1 commit into
mainfrom
chore/remove-unused-phabricator-config
Oct 17, 2026
Merged

nickolas-dimitrakas merged 1 commit into
mainfrom
chore/remove-unused-phabricator-config

Conversation

@nickolas-dimitrakas

Copy link
Copy Markdown
Contributor

Why

The repository still carries a configuration file for a code review tool the project stopped using years ago. It does nothing today, but it points readers and tools at a review process that no longer exists. Once this lands, that stale file is gone, so nothing in the repository points at the old review process.

Programme

Standalone change, no programme.

What changes

Before: the repository root has .arcconfig, a Phabricator configuration file. After: the file is gone. Nothing in the repository reads or references it, so no source, build, test or release file changes. The changelog is not edited, because nothing that ships in the SDK changes.

Linked work

None.

Rollout

Nothing changes in production; if this is wrong, revert the pull request.

Risks

  • Someone still relies on the file for local tooling; nothing in the repository references it and the tool it configures is no longer used; we would see a question on this pull request or an issue.

Risk class: low.

Who

Written by: an automated coding agent, at a maintainer's request.
Code reviewed before opening: no one.
Design reviewed before opening: no one.
Decision this implements: a maintainer's request to remove unused tooling configuration.
Checked: a search of the repository for references to .arcconfig, outside the file itself, found none.
Not checked: an IDE or Gradle run, since no build input changes.

Size

Hand-written: 4 lines removed in 1 file.
Generated: none

The .arcconfig file configures a code review tool the project no
longer uses, and nothing in the repository references it.
@nickolas-dimitrakas
nickolas-dimitrakas requested a review from a team as a code owner October 17, 2026 07:14
@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Oct 17, 2026
@github-actions

Copy link
Copy Markdown

Kotlin migration progress

No change to the Java left to convert.

Module Kotlin LOC Java LOC Java staying (facade) Java left to convert Kotlin share
android-core 3,249 22,690 9,716 12,974 12.5%
android-kit-base 601 5,405 1,651 3,754 10.0%
Total 3,850 28,095 11,367 16,728 12.1%

Conversion progress: 0.0% (16,728 of 16,550 baseline Java LOC left to convert). 132 Java files and 36 Kotlin files in scope.

@github-actions

Copy link
Copy Markdown

Binary compatibility

  • ✅ android-core is compatible with 6.1.9 (115 classes compared, 0 with additions only).
  • ✅ android-kit-base is compatible with 6.1.9 (44 classes compared, 0 with additions only).

Compares the release AAR against the same artifact at the last version published to Maven Central; R8-renamed classes and members are excluded (see the script docstring). Full japicmp HTML/XML reports are attached as the api-compat-reports workflow artifact. This check is not in the required-check set yet, so a red result here does not block merging.

@github-actions

Copy link
Copy Markdown

📦 SDK Size Impact Report

What the SDK adds to a minified release APK.

mParticle Core SDK

Measured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.

Metric Target branch This PR Change
APK size 120.63 KB 120.63 KB +1 bytes
Download size 118.45 KB 118.44 KB -3 bytes
Dex bytes 215.25 KB 215.25 KB 0 bytes

mParticle Core + Rokt kit

Measured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see size-report-rokt/README.md.

Metric Target branch This PR Change
APK size 1.26 MB 1.26 MB 0 bytes
Download size 1.25 MB 1.25 MB +1 bytes
Dex bytes 2.23 MB 2.23 MB 0 bytes

Rokt SDK+ umbrella (adds the payment extension)

Metric Target branch This PR Change On top of mParticle Core + Rokt kit
APK size 6.55 MB 6.55 MB 0 bytes +5.29 MB
Download size 6.43 MB 6.43 MB +1 bytes +5.19 MB
Dex bytes 7.12 MB 7.12 MB 0 bytes +4.88 MB

➡️ SDK size impact change is minimal.

Raw measurements

core, Target branch:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2508, "baseline_install_bytes": 7525, "core_dex_bytes": 220412, "core_download_bytes": 123798, "core_install_bytes": 131048}

core, This PR:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2515, "baseline_install_bytes": 7531, "core_dex_bytes": 220412, "core_download_bytes": 123802, "core_install_bytes": 131055}

rokt, Target branch:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4170020, "kit_download_bytes": 2548122, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9291568, "sdkplus_download_bytes": 7985699, "sdkplus_install_bytes": 8165359}

rokt, This PR:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4170020, "kit_download_bytes": 2548123, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9291568, "sdkplus_download_bytes": 7985700, "sdkplus_install_bytes": 8165359}

Measured a51b464 merged into 5d8ddf3

@nickolas-dimitrakas
nickolas-dimitrakas merged commit 6c507d8 into main Oct 17, 2026
46 checks passed
@nickolas-dimitrakas
nickolas-dimitrakas deleted the chore/remove-unused-phabricator-config branch October 17, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants