Sync fixes from LovyanGFX develop and bump version to 0.2.26#228
Merged
Conversation
- pgmspace.h: make pgm_read_3byte_unaligned alignment-safe on platforms without pgm_read_dword_with_offset (lovyan03/LovyanGFX#865) - LGFX_Sprite.cpp: accept valid top-down BMP imports and reject INT32_MIN height (lovyan03/LovyanGFX#864) - pixelcopy.hpp: restore ARGB8888 destinations in get_fp_copy_rgb_affine (lovyan03/LovyanGFX#862) All three files are byte-identical with LovyanGFX develop after this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port three fixes that landed on LovyanGFX develop:
pgmspace.h: makepgm_read_3byte_unalignedalignment-safe on platformswithout
pgm_read_dword_with_offset, so 24-bit reads no longer performmisaligned dword access (Make 24-bit sprite reads alignment-safe lovyan03/LovyanGFX#865)
LGFX_Sprite.cpp: accept valid top-down BMP imports (negative biHeight)and reject the INT32_MIN height edge case (Fix createFromBmp for top-down BMPs lovyan03/LovyanGFX#864)
pixelcopy.hpp: restore the ARGB8888 destination entries inget_fp_copy_rgb_affine, fixing a null function pointer when copying toARGB8888 sprites (Fix null function pointer for ARGB8888 destination in get_fp_copy_rgb_affine lovyan03/LovyanGFX#862, fixes pushImage/drawPngFile: null fp_copy when decoding a PNG with alpha directly into an ARGB8888-depth sprite lovyan03/LovyanGFX#855)
All three files are byte-identical with LovyanGFX develop after this change,
keeping the shared core in sync between the two repositories.
Checks
git diff --check