[WRONG BRANCH] fix(cursor): remove spoofable connection status - #424
[WRONG BRANCH] fix(cursor): remove spoofable connection status#424luvs01 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fbd6019d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return { | ||
| ...base, | ||
| state: seenRecently ? "current" : "absent", | ||
| state: "absent", |
There was a problem hiding this comment.
Represent unverifiable Cursor wiring as unknown
Whenever Private Inference is installed, this unconditional absent state renders the literal “Not applied” badge and excludes Cursor from the applied count, including when Cursor is correctly configured. Since this code explicitly acknowledges that the configuration cannot be verified, the change replaces spoofable false positives with deterministic false negatives; use an unknown/unverifiable visual state while continuing not to count it as applied.
Useful? React with 👍 / 👎.
| * questions the dashboard needs — which Cursor builds are installed, what to paste into the | ||
| * gateway form, and whether a Cursor client has actually called `/v1/models` since the proxy | ||
| * started — plus which active models will show Cursor's Reasoning and Context controls. | ||
| * gateway form, and which active models will show Cursor's Reasoning and Context controls. |
There was a problem hiding this comment.
Update guidance after removing last-seen status
After this route stops returning the last-seen signal, docs-site/src/content/docs/guides/cursor-private-inference.md:74-93 still says the dashboard shows whether the gateway values took and that Refresh model list flips a Connection card, while docs-site/src/content/docs/guides/integrations.md:62-67 and src/cli/capabilities.ts:500-508 still promise the last request seen. Users and agents are therefore directed to a diagnostic that no longer exists; update the English and localized docs, change the capability summary, and regenerate skills/ocx/references/01_management_surface.md.
AGENTS.md reference: src/AGENTS.md:L29-L29
Useful? React with 👍 / 👎.
Motivation
User-Agent: Cursor/<version>as authoritative evidence that Cursor had contacted the proxy, but the header is caller-controlled and can be spoofed by any admitted data-plane client.Description
User-Agentvalues. (deletedsrc/integrations/cursor-seen.ts, removedrecordCursorSeenusage insrc/server/index.ts).lastSeenfrom the management status contract and stop returning or relying on the spoofable record inGET /api/native-integrations/cursor. (src/server/management/cursor-integration-routes.ts).gui/src/pages/integrations/CursorIntegrationPage.tsx,gui/src/pages/integrations/cursor-api.ts,gui/src/pages/integrations/overview-clients.ts).lastSeen(updatedtests/cursor-integration-status.test.ts,gui/tests/cursor-integration-page.test.tsx,gui/tests/integrations-overview-rows.test.ts).Testing
bun test ./tests/cursor-integration-status.test.tsand it passed.cd gui && bun test ./tests/cursor-integration-page.test.tsx ./tests/integrations-overview-rows.test.tsand they passed.bun run typecheck,cd gui && bun run lint,cd gui && bun run build, andbun run privacy:scan, all of which succeeded for the modified code.bun run test) and it reported unrelated failures/timeouts across many integration tests; the focused Cursor suites and the required type/lint/build/privacy checks for this PR passed.Codex Task