docs(security): harden remote-hub guidance to avoid Tailscale header spoofing - #409
docs(security): harden remote-hub guidance to avoid Tailscale header spoofing#409luvs01 wants to merge 20 commits into
Conversation
release: promote dev into main for v2.32.1
# Conflicts: # package.json
[WRONG BRANCH] merge dev into main for the v2.33.0 release
Promotes the dev integration line onto main. The resulting tree is byte-identical to origin/dev, including package.json at 2.34.0. The package.json conflict is resolved to dev's side, NOT to main's stale 2.33.0. Earlier promotions (lidge-jun#2553, lidge-jun#2507) kept the target's version so the release bump would land on its own "release: vX.Y.Z" commit. That is no longer legal: this very delta adds tests/release-version-line.test.ts, which fails when the in-tree version sits behind the highest release tag. With v2.34.0-preview.20260827 now published, 2.33.0 orders behind it, so a promotion carrying the stale line turns CI red on every shard that runs the suite. The consequence for the release step is that scripts/release.ts skips the bump (release.ts:568, currentVersion === version), so v2.34.0 gets tagged on this merge commit rather than on a separate release commit. The workflow creates the tag itself after publishing and validates expected-sha against the checked-out commit, so the tag still names exactly the audited tree.
[WRONG BRANCH] promote dev onto main for v2.34.0
[WRONG BRANCH] promote dev onto main for v2.35.0
[WRONG BRANCH] promote dev onto main for v2.36.0
[WRONG BRANCH] promote dev to main for the v2.37.0 release
[WRONG BRANCH] promote dev onto main for v2.38.0
[WRONG BRANCH] promote dev onto main for v2.39.0
release: promote dev to main for v2.40.0
…rkflow call (lidge-jun#3262) Both v2.40.0 release dispatches (33615174183 preview, 33615177849 main) died at startup_failure: a workflow_call cannot grant its callee more than the calling job holds, and dev-version-bump.yml's job declares contents+pull- requests write. lidge-jun#3129 wired the call but never dispatched a release, so this is its first live run. The caller job now declares exactly the callee's two permissions; no other job in release.yml gains anything. Co-authored-by: jun <jun@lidge.dev> (cherry picked from commit 7ce0ba5)
…400-relfix release: carry the release.yml permissions fix onto main for v2.40.0
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
added
the
documentation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
changed the title
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bae06747bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `127.0.0.1:10101`. A generic TLS proxy does not supply trustworthy Tailscale identity. Keep | ||
| `remoteGui.allowedTailscaleUsers` empty, and configure the proxy to remove or reject every incoming | ||
| `Tailscale-User-*` header before forwarding. Preserving client-supplied identity headers is unsafe; | ||
| do not merely avoid adding new ones. Use the single-use, origin-bound pairing flow instead. |
There was a problem hiding this comment.
The French, Japanese, Korean, Russian, Turkish, Simplified Chinese, and Traditional Chinese guides/remote-hub.md pages still set remoteGui.allowedTailscaleUsers before Tailscale Serve is established and tell generic-proxy operators only not to fabricate identity headers, without requiring removal of client-supplied headers. Users following any localized guide therefore remain exposed to the header-spoofing path this change is intended to close; update every directly affected translation with the empty-by-default allowlist and header-stripping requirement.
AGENTS.md reference: docs-site/AGENTS.md:L7-L10
Useful? React with 👍 / 👎.
| management ingress: | ||
|
|
||
| ```bash | ||
| ocx config set remoteGui.allowedTailscaleUsers '["operator@example.com"]' |
There was a problem hiding this comment.
In the documented systemd/launchd sequence, ocx service install starts the hub while this setting is still empty, and this later ocx config set only persists config.json; startServer captures the configuration once at startup in src/server/index.ts:645, with no live reload for remoteGui. Consequently the allowed Tailscale user still cannot mint a session and the positive dashboard step fails until the service is restarted. Add ocx service restart after this command, or establish Serve and set the allowlist before installing the service.
Useful? React with 👍 / 👎.
luvs01
changed the title
2 participants
Motivation
Tailscale-User-*headers and thus let an attacker mint long-lived GUI sessions.Description
remoteGui.allowedTailscaleUsersallowlist to an empty list in the remote-hub guide and the container/Compose examples so no remote identity can mint a session by default.Tailscale-User-*headers before forwarding and to prefer the origin-bound pairing flow for generic frontends.docs-site/src/content/docs/guides/remote-hub.mdandstructure/05_gui-and-management-api.md.Testing
git diff --check(no whitespace or diff-check issues detected).cd docs-site && bun install --frozen-lockfile && bun run buildcompleted successfully.bun run typecheckandbun run privacy:scanboth passed.bun run testwas started but the full test run surfaced unrelated pre-existing failures in some Lab and routing test suites; the focused validation steps above and the docs build passed and were used to verify the documentation and formatting changes.Codex Task