fix(release): ignore fork PRs in bump guard - #402
Conversation
release: promote dev into main for v2.32.1
# Conflicts: # package.json
[WRONG BRANCH] merge dev into main for the v2.33.0 release
Promotes the dev integration line onto main. The resulting tree is byte-identical to origin/dev, including package.json at 2.34.0. The package.json conflict is resolved to dev's side, NOT to main's stale 2.33.0. Earlier promotions (lidge-jun#2553, lidge-jun#2507) kept the target's version so the release bump would land on its own "release: vX.Y.Z" commit. That is no longer legal: this very delta adds tests/release-version-line.test.ts, which fails when the in-tree version sits behind the highest release tag. With v2.34.0-preview.20260827 now published, 2.33.0 orders behind it, so a promotion carrying the stale line turns CI red on every shard that runs the suite. The consequence for the release step is that scripts/release.ts skips the bump (release.ts:568, currentVersion === version), so v2.34.0 gets tagged on this merge commit rather than on a separate release commit. The workflow creates the tag itself after publishing and validates expected-sha against the checked-out commit, so the tag still names exactly the audited tree.
[WRONG BRANCH] promote dev onto main for v2.34.0
[WRONG BRANCH] promote dev onto main for v2.35.0
[WRONG BRANCH] promote dev onto main for v2.36.0
[WRONG BRANCH] promote dev to main for the v2.37.0 release
|
✅ Deterministic PR hygiene checks passed. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
changed the title
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 530c16b091
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # `--head` matches only the branch name, including identically named fork | ||
| # branches. Count only pull requests whose head belongs to this repository; | ||
| # otherwise a fork can pre-open the predictable branch and suppress the bump. | ||
| open_prs="$(gh pr list --base dev --head "${branch}" --state open --json number,isCrossRepository --jq '[.[] | select(.isCrossRepository == false)] | length')" |
There was a problem hiding this comment.
When an upstream bump PR is already open and at least 30 same-named fork PRs precede it in gh pr list's results, the upstream PR is truncated before this jq filter runs: gh pr list --help documents a default --limit of 30. The filter then reports zero upstream PRs and falls through to gh pr create, which fails because that upstream PR already exists, turning a rerun into a red release job. Request sufficient results (or paginate) before filtering.
Useful? React with 👍 / 👎.
luvs01
changed the title
2 participants
Motivation
codex/dev-version-${NEXT_VERSION}from suppressing the repository-owned bump PR.Description
.github/workflows/dev-version-bump.ymlto querygh pr list --json number,isCrossRepositoryand count only PRs withisCrossRepository == false, excluding fork PRs from the idempotency guard.tests/bump-dev-version.test.tsthat asserts the workflow contains the--json number,isCrossRepositoryquery and theselect(.isCrossRepository == false)filter.Testing
bun test tests/bump-dev-version.test.ts, which passed the new assertions and most cases, with one environment-specific unwritable-directory test failing due to container filesystem semantics (known/expected in this environment).bun run privacy:scanwhich passed.git diff --checkandbun run prepushchecks wheretypecheckandguilint passed but the repository-wide test run reported unrelated existing/time-sensitive failures, so full-suite CI remains the authoritative gate.Codex Task