ci(launcher): cap macOS job at 120m for slow notarization#302
Merged
Conversation
Apple notarization can sit in the queue ~45+ min with no incident (observed 49m). A job-level timeout-minutes: 120 bounds a genuinely stuck submission at 2h instead of GitHub's 6h default, without the false-failures a tight notarytool --timeout would cause. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the signed-launcher work. The first successful signed run notarized fine but Apple's queue took ~49 min with no posted incident.
Adds
timeout-minutes: 120to the macOS job so a genuinely stuck submission fails at 2h instead of GitHub's 6h default — while leaving comfortable margin over real-world notarization latency.Deliberately not using
notarytool --timeout: that abandons the local wait without cancelling the submission, so a tight value (e.g. 30m) would have false-failed today's valid 49-min notarization and left an unstapled DMG. A generous job-level cap is the safer backstop.🤖 Generated with Claude Code