Repository navigation
DM-56116: Support lsst.images format for AP metric inputs - #494
Merged
Merged
Conversation
isullivan
force-pushed
the
tickets/DM-56116
branch
from
September 28, 2026 12:18
cec77e6 to
d66899f
Compare
isullivan
force-pushed
the
tickets/DM-56116
branch
3 times, most recently
from
October 6, 2026 16:51
5193342 to
8a33308
Compare
TallJimbo
approved these changes
Oct 6, 2026
| else: | ||
| name = f"{parent}.summaryStats" | ||
| storage_class = "ExposureSummaryStats" | ||
| self.data = dataclasses.replace(self.data, name=name, storageClass=storage_class) |
Member
There was a problem hiding this comment.
Doing a connection dataset type rename after the config has been frozen is (AFAIK) new territory, and while I don't see a specific reason why it's unsound, that worries me. But given that you do need to do the storage class name override here (and that is an established pattern), let's give it a try. It might be that this a perfectly acceptable pattern we should use in other places, too.
Contributor
Author
There was a problem hiding this comment.
I've expanded the docstring of the data input connection to clarify the behavior.
isullivan
force-pushed
the
tickets/DM-56116
branch
from
October 6, 2026 22:34
8a33308 to
b20209a
Compare
isullivan
force-pushed
the
tickets/DM-56116
branch
from
October 12, 2026 18:50
b20209a to
ca99343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.