fix: off-by-two in printinaddr remaining-length accounting#366
Merged
Conversation
In printinaddr(), the remaining-length counter nl was decremented by len - 1 instead of len + 1 after writing ":" + port string (len + 1 bytes). This inflated nl by 2 after each port field, allowing the final snpf() to write 2 bytes past the end of the heap-allocated Namech buffer. Reported-by: f9j2n6nd8k-eng Fixes #365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
printinaddr(), the remaining-length counternlwas decremented bylen - 1instead oflen + 1after writing ":" + port string (len + 1bytes). This inflatesnlby 2 after each port field, allowing the finalsnpf()to write 2 bytes past the end of the heap-allocatedNamechbuffer.Reported-by: f9j2n6nd8k-eng
Fixes #365