feishu: card rollover never fires — long tasks silently stop updating #814

Activity

1. cuipengcx90 commented on Sep 21, 2026

   

   cuipengcx90

   on Sep 21, 2026

   ContributorAuthor

   More actions

   Update: fixed locally in my fork, using button pagination instead of multi-card rollover.

   Approach

   • The card now renders ◀ prev / N/M / next ▶ at the bottom; each button's value carries {ga_card, page}.
   • Registered via register_p2_card_action_trigger; the callback resolves the card instance from a uid registry and re-patches the same message, so the whole step history stays browsable in one card.
   • Pagination uses dual criteria: max 50 steps and 8000 chars per page. Measured from real logs: the original overflow fired around step 58, with single-step detail averaging 272 chars (max 9003), so a step-count-only limit is not enough.

   Both underlying defects are also fixed

   • _rollover_locked() now clears self.steps and advances turn_base, so a rollover page is actually smaller and step numbering stays contiguous.
   • _push_sync() returns limit=True on the create path when it fails, so the caller can roll over and retry instead of leaving msg_id = None forever.

   Result: no more silent card failures, and long tasks no longer need a manual "continue".

   Happy to open a PR if this fits your design — the alternatives (multi-message rollover, or a rolling window that drops old steps) both hurt reviewability.
2. louisss1016 commented on Oct 1, 2026

   

   louisss1016

   on Oct 1, 2026

   More actions

   I'd like to take this one, scoped to the two defects and the minimal fix suggested in the issue body:

   • _rollover_locked() clears self.steps and carries turn_base so step numbering stays contiguous and the new card is actually smaller;
   • _push_sync() returns limit=True when the create path fails, so _worker_loop rolls over and retries instead of the card becoming permanently unsendable.

   @cuipengcx90 you mentioned a local fork fix using button pagination — I'm deliberately not attempting the pagination rework here, keeping this PR to the rollover defects so the two approaches can coexist (yours is the nicer long-term UX; this unblocks the silent-stop failure mode with a small diff). If you'd rather own the whole thing, say the word and I'll drop this.
3. louisss1016 commented on Oct 1, 2026

   

   louisss1016

   on Oct 1, 2026

   More actions

   PR up: #820

   Important finding while implementing: the code the issue references (_rollover_locked() / _push_sync() / _worker_loop, _DETAIL_LIMIT = 4000) does not exist on current main. A rollover implementation was merged in #209 (bf002e5b) but was dropped in the later Feishu interface rework (df525560) — main today has no rollover at all, and the original freeze symptom reproduces structurally.

   So this PR re-lands the rollover behavior adapted to the current _TaskCard:

   • _push() returns (ok, limit); the create path reports limit=True on failure (your defect 2 — with msg_id is None every push took the create path and never rolled over)
   • _rollover() clears steps so the continuation card is actually smaller (your defect 1)
   • turn_base + monotonic turn_no keep Turn N contiguous across cards
   • proactive flip at 50 steps — just under your measured ~58-step overflow point

   @cuipengcx90 as agreed, scoped to the rollover defects only; your button-pagination fix is complementary and untouched here.

   11 new tests (ast/exec pattern); full suite 298 passed, same 3 pre-existing Windows-env failures as before my change.