Skip to content

Fix DoP playback transitions, seeking, and cue metadata#504

Open
markojurkovic wants to merge 1 commit into
losnoco:mainfrom
markojurkovic:feat/dsd-over-pcm-support-improvements-fade-disable-option
Open

Fix DoP playback transitions, seeking, and cue metadata#504
markojurkovic wants to merge 1 commit into
losnoco:mainfrom
markojurkovic:feat/dsd-over-pcm-support-improvements-fade-disable-option

Conversation

@markojurkovic

@markojurkovic markojurkovic commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR improves DSD-over-PCM (DoP) playback and fixes cue-sheet track metadata.

Changes

  • Prevents clicks when pausing, resuming, or switching DoP tracks.
  • Preserves DoP data by bypassing fades, volume scaling, and crossfading.
  • Maintains the correct DoP marker phase across buffer boundaries.
  • Outputs valid DoP silence during pauses, underruns, and transitions.
  • Adds a seek barrier to prevent corrupted transitional data from reaching the DAC.
  • Fixes noise after seeking within DoP tracks.
  • Adds a preference to disable playback transition fading.
  • Fixes cue sheets assigning the first track’s title to every track.
  • Fixes a fader lock leak during buffer resets.

Testing

  • Built the CogAudio framework successfully.
  • Tested DoP detection, marker alternation, odd-sized buffers, silence generation, and invalid-marker rejection.
  • Verified both consolidated patches apply cleanly to the current main branch.

- preserve DoP data during pause, resume, seeking, and track changes
- maintain marker phase and emit valid DoP silence across interruptions
- prevent fades, volume scaling, and crossfades from corrupting DoP streams
- add an option to disable playback transition fading
- fix duplicate track titles when loading cue sheets
- fix a fader lock leak during buffer resets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant