Repository navigation
Also test e2e on linux and update config with latest hash - #692
Merged
Merged
Conversation
…in dependency update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like the pattern to use is {pak} for sys deps discovery and then install them in second step. In our template in #690, we'd need to also install the system requirements for the pre-commit environments. However, that's not trivial. Taking the version of {precommit} from the config file is insufficient, since
renv.lockand dependencies inDESCRIPTIONare not the same. Also,additional_dependeniescould have more system dependencies.Also, this needs to happen before the renv is created, so we could not rely on the
renv.lockanyways.Pragmatic solution:
Exception:r-lib/pkgapi-> {usethis} -> {gert}.dependencies=TRUEseems to do the trick for most cases.