Skip to content

Also test e2e on linux and update config with latest hash - #692

Merged
lorenzwalthert merged 13 commits into
mainfrom
fix/usethis-readme-hook-detection
Oct 5, 2026
Merged

lorenzwalthert merged 13 commits into
mainfrom
fix/usethis-readme-hook-detection

Conversation

@lorenzwalthert

@lorenzwalthert lorenzwalthert commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner
  • macOS previously did not fail because of missing system dependencies, only Linux does, so we added it in end to end tests.
  • we can also use that latest SHA already in pre-commit's config to test if CI systems can use it. This is more of an end to end test as well.

Seems like the pattern to use is {pak} for sys deps discovery and then install them in second step. In our template in #690, we'd need to also install the system requirements for the pre-commit environments. However, that's not trivial. Taking the version of {precommit} from the config file is insufficient, since renv.lock and dependencies in DESCRIPTION are not the same. Also, additional_dependenies could have more system dependencies.

Also, this needs to happen before the renv is created, so we could not rely on the renv.lock anyways.

Pragmatic solution:

  • dependencies don't change often.
  • additional dependencies come from roxygen hook ,which corresponds to the dependencies of the source package. Exception: r-lib/pkgapi -> {usethis} -> {gert}.
  • Installing system dependences of both precommit and local package with dependencies=TRUE seems to do the trick for most cases.

@lorenzwalthert
lorenzwalthert merged commit 6b5c19b into main Oct 5, 2026
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant