Skip to content

OpenAPI 1.21.1#6

Open
danrowden wants to merge 2 commits into
mainfrom
dan/openapi-1.21.1
Open

OpenAPI 1.21.1#6
danrowden wants to merge 2 commits into
mainfrom
dan/openapi-1.21.1

Conversation

@danrowden

Copy link
Copy Markdown
Collaborator

Workflow, event patterns, create segments, create/update themes and components, and more.

@danrowden
danrowden requested a review from fantactuka July 23, 2026 10:57

@fantactuka fantactuka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, but looks great!

Comment thread src/Themes.php Outdated
Comment thread src/Workflows.php
public function changeMailingList(
string $workflow_id,
?string $expected_revision_id,
mixed $mailing_list_id,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be ?string too?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mailing list is a required string, if that's what you mean?

Comment thread src/Workflows.php Outdated
@danrowden

Copy link
Copy Markdown
Collaborator Author

Fixed the param filtering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants