Repository navigation
Fail certificate setup when Match fails and no renewal will run - #820
Merged
Merged
Conversation
marionbarker
approved these changes
Nov 12, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve by comparison with same file in LoopWorkspace, v3.14.12 ignoring white space differences.
This was tested prior to merging LoopWorkspace PR 573
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create Certificates ignores the exit status of the certs lane so that an expired Distribution certificate can be nuked and recreated. When Match rejects the certificate stored in Match-Secrets while the team has another valid Distribution certificate, no renewal runs, the job succeeds and the build fails later at signing. The certs step now records whether the lane failed, and the job fails with an error saying to delete Match-Secrets when no renewal will follow and FORCE_NUKE_CERTS is not set. The certs lane checks the watch identifiers before match, so a missing watch setup fails with the existing setup message. Port of LoopKit/LoopWorkspace#573, adapted for the watch identifiers.