Repository navigation
Simplify sync operation resets and Journal adapters - #110
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Journal repeats graph-operation cleanup across six reducer transitions, carries unused graph metadata through its readiness notification, and parses/maps attachment selections more than once. This change removes those duplicate obligations while preserving existing behavior.
failpolicy.Graph_readypayload-free. Preserve the actualV2_graph_inforequest, correlation/failure handling, task-catalog startup and separate admission inspection; worker wire formats are unchanged.to_importmapping. Preserve public attachment entry points, typed/UUID validation, request identity, errors, batch order andreplace_reference=None.No permanent tests, dependencies, Dune, protected specs or Swift changes.
Validation
The focused build and these seven existing test commands passed both before and after:
test/journal_routes_test.exetest/journal_platform_test.exetest/journal_graph_runtime_locality_test.exe— 152 casestest/application_view_test.exe— 144 cases, including admission/unlocktest/logseq_db_worker_application_integration_test.exe— 15 caseslogseq_sync/test/test_sync.exe test 'pure core'— 87 caseslogseq_sync/test/test_sync.exe test 'sync recovery reproductions'— 21 casesTemporary external harnesses compared 1,972 reducer input/public-state/context/ordered-effect records, 5,906 runtime input/request/notification records, and 74 attachment cases byte-for-byte. Baseline replay was deterministic. Runtime comparison normalizes only the intentionally removed
Graph_readyargument; scenarios include success, duplicate, failure, abandonment, reset and old completions. Attachment cases cover valid/invalid inputs, exact errors, request IDs and ordered batches. No temporary harness or logs are committed.Native Swift startup/failure boundary checks also passed (21 scenarios). Independent review of exact head
362796efound no actionable regression.git diff --checkand decision-document validation pass.Limits
Whole-file formatting checks fail on the same four ML files before and after; the MLI passes both. No broad formatting changes were made. Validation uses synthetic inputs and public observations, not opaque reducer internals or a formal equivalence proof. No full App build/full test alias, GUI, Simulator/device, benchmark or real-graph acceptance was run.