Repository navigation
Tests: the house rules run through samebytes v0.3.0 (docs, source) - #5
Merged
Merged
Conversation
The hand-written ASCII, docstring, import, quiet-import, printed-string, link and structure checks become calls into samebytes.docs and samebytes.source, the one copy the family shares, pinned as a test extra. The package and its runtime dependencies are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_rules.pykeeps the quiet-import, printed-ASCII, no-print-outside-the-CLI, version and README-anchor rules, now run through samebytes. samebytes is a test extra; the package's runtime dependencies are unchanged. The package-specific tests stay as written (cargo imports neither the catalog nor spacecost, lazy names, changelog, contract).The rules now live in samebytes v0.3.0 (
samebytes.docs,samebytes.source; loggger101/samebytes#4). That release replaces the five or six hand-written copies of each rule that the repositories in this family had kept, which had drifted apart.test_import_creates_nothingmerges intotest_import_is_silent:quiet_importruns in an empty directory and fails if anything is created.Verified
printinrelease.py, a non-ASCIIprintin the CLI, a broken README anchor, and aprintat import time.