Skip to content

Upgraded to PROJ 9.8.1 - #134

Closed
emilevictor wants to merge 1 commit into
locationtech:masterfrom
emilevictor:main
Closed

Upgraded to PROJ 9.8.1#134
emilevictor wants to merge 1 commit into
locationtech:masterfrom
emilevictor:main

Conversation

@emilevictor

Copy link
Copy Markdown

No description provided.

@pomadchin

Copy link
Copy Markdown
Member

Hi there; thanks for the massive effort; however there are two things to note;

  1. Would ask to sign https://www.eclipse.org/legal/eca/ // ECA form link
  2. It is a bit too radical of a change; as the library needs some love that's true, but mb step by step?
  • I've been recently working on Align code / tests with the most recent PROJ #133 to at least align what we have with min changes involved; the changes are sensitive so just rewriting everything might lead to not obvious regressions; and whatever works now might get broken.

Comment thread pom.xml
Comment on lines +4 to +5
<groupId>io.github.emilevictor.neoproj4j</groupId>
<artifactId>neoproj4j-modules</artifactId>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can't be merges as is.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pomadchin , give me a moment - I have forked it in https://github.com/emilevictor/neoProj4J - will close this PR for the moment.

My plan is to develop there, integrate into the project that I'm working on, test, and then iterate with you guys until we are happy for it to actually get back to this repo. It is currently AI slop (albeit, with better results on the conformance testing than the main project), so this might take a bit of doing.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hence me forking.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

Comment thread README.md
@@ -1,22 +1,42 @@
# Proj4J [![GitHub Action Status](https://github.com/locationtech/proj4j/workflows/CI/badge.svg)](https://github.com/locationtech/proj4j/actions) [![Maven Central](https://img.shields.io/maven-central/v/org.locationtech.proj4j/proj4j)](https://search.maven.org/search?q=g:org.locationtech.proj4j%20AND%20a:proj4j)
# neoProj4J

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb this PR was intended for a different repo?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for now I want to fork it and then work with you on potentially longer term getting it back in if we get it to a point we are happy with.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't intend to push to the main repo.

Comment thread .mvn/jgitver.config.xml
Comment on lines +8 to +11
<!-- Default is `master` alone. `main` is this repository's default branch, so
without it every build here would be X.Y.Z-main-SNAPSHOT. A clean X.Y.Z still
requires HEAD to be exactly an annotated vX.Y.Z tag. -->
<nonQualifierBranches>main,master</nonQualifierBranches>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was the intent

@emilevictor emilevictor closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants