Repository navigation
Drop two unused restricted jars: opendap 2.1 and findbugs annotations 2.0.1 - #1994
Merged
Merged
Conversation
… 2.0.1 opendap:opendap:2.1 came in through gt-netcdf. Nothing loads it: neither gt-netcdf nor NetCDF-Java 5.5.3 refers to its opendap.dap classes, and NetCDF-Java 5's own DAP support is a separate artifact that GeoWave does not use. GeoTools still finds and initialises its NetCDF format without it. com.google.code.findbugs:annotations:2.0.1 came in through the reflections 0.9.10 that services/rest pinned. The gRPC modules already used 0.9.11, which dropped that dependency, so reflections is now managed once, at 0.9.11. Both needed source-code attachments for Eclipse IP review. Restricted dependencies go from 27 to 25. Co-authored-by: Rich Fecher <richard.fecher@vantor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IP team could not process eight libraries automatically; each needs its source attached in IPLab. Six already left the 3.0 dependency graph with #1979: Sun JAI (
jai_core,jai_codec,jai_imageio),h21.1.119,geodb0.9 and GeoServer 2.19'sjson-libfork. This PR removes the other two, neither of which anything uses.opendap:opendap:2.1came in through GeoTools'gt-netcdf. It is a 2009 OPeNDAP library that nothing loads: none ofgt-netcdf's classes, or NetCDF-Java 5.5.3's (cdm-core,bufr,netcdf4,udunits,httpservices), refers to itsopendap.dappackages. NetCDF-Java 5's own DAP support is a separate artifact that GeoWave doesn't include. It is excluded in the root pom'sgt-netcdfentry.com.google.code.findbugs:annotations:2.0.1came in through thereflections0.9.10 pinned inservices/rest. The gRPC modules already used 0.9.11, which dropped that dependency and is approved (CQ16665).reflectionsis now managed once, at 0.9.11.Verification (JDK 21, local)
services/rest: 46 unit tests pass, formatter validation and SpotBugs clean. This includes the test that checks every REST route appears in the API description, which exercises the classpath scan.reflectionsuser, generates the same 8.protofiles.geowave-format-geotools-raster's runtime classpath minusopendap, GeoTools'GridFormatFinderstill lists the NetCDF format, andNetCDFUtilitiesanducar.nc2.NetcdfFileinitialise.Eclipse IP
DEPENDENCIES, regenerated with Dash: 797 entries, 21 restricted (master's file says 27).findbugs annotations2.0.1,opendap2.1 andreflections0.9.10.hadoop-mapreduce-client-app,-hs,hadoop-miniclusterandhadoop-minikdc3.4.3.