crypto: harden IBM Z AES and ECDSA constant-time paths - #95
Merged
Conversation
Remove unused KM key expansion and use the generalized fixslice fallback on s390x. Replace ECDSA wide reduction and Fermat inversion with fixed-work arithmetic while binding DudeCT gates to ct.toml.
Keep only cheap branch, outgoing-diff, syntax, conditional Cargo graph, and release-intent checks in the push path. Move compilation, tests, action analysis, and exhaustive assurance back to explicit validation commands and hosted CI.
loadingalias
marked this pull request as ready for review
August 27, 2026 01:37
Store fixslice schedules inline on s390x while retaining the existing boxed representation for alloc-enabled RV64. This restores zero-allocation header-protection and AES-SIV construction on IBM Z fallback systems.
Keep the all-zero/all-one mask opaque to LLVM so IBM Z retains bitwise selection during wide-order reduction. This removes the secret-dependent jumps observed by native DudeCT without changing scalar results.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Follow-up evidence
The CT workflow is intentionally not run by this PR creation step. Native CT evidence will be run separately after the normal required CI suite is green.