aead: expose typed header-protection masks - #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security and performance
The API fixes key and sample sizes in the type system, exposes only the five-byte mask, and keeps raw primitive mechanics under the existing
expertcapability boundary. AES key schedules and ChaCha20 keys are cleared on drop, with compiler-level zeroization evidence. The implementation does not introduce protocol-specific names or behavior.Measured AArch64 and x86_64 results show the native rscrypto paths materially ahead of the equivalent RustCrypto header-protection work; the benchmark catalog records the workloads without extending claims beyond measured targets.
Focused validation
cargo clippy --locked --no-default-features --features aes-gcm,chacha20poly1305,aegis256 --lib --tests -- -D warningscargo clippy --locked --target x86_64-unknown-linux-gnu --no-default-features --features aes-gcm,chacha20poly1305 --lib -- -D warningscargo test --locked --no-default-features --features aes-gcm,chacha20poly1305,aegis256 --lib --test header_protection --test secret_redactionjust ct-validate --target aarch64-apple-darwin --manifest-onlyjust check-zeroize-evidencescripts/ci/nostd-wasm-suite.sh wasm32-wasip1 shallow