Skip to content

ci(ldk): also run fmt/clippy in workloads/ldk - #203

Open
ekzyis wants to merge 1 commit into
lnfuzz:masterfrom
ekzyis:ci-workloads-ldk
Open

ci(ldk): also run fmt/clippy in workloads/ldk#203
ekzyis wants to merge 1 commit into
lnfuzz:masterfrom
ekzyis:ci-workloads-ldk

Conversation

@ekzyis

@ekzyis ekzyis commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

close #201

Btw, I can recommend running the quick part of the CI locally before committing with git hooks:

$ mkdir .githooks
$ cat > .githooks/pre-commit <<EOF
# pre-commit hook

set -xeu

cargo fmt --all --check
cargo fmt --check --manifest-path workloads/ldk/Cargo.toml
cargo clippy --all-features --all-targets -- -D warnings
cargo clippy --all-targets --manifest-path workloads/ldk/Cargo.toml -- -D warnings
cargo test --all-features --all-targets
EOF
$ git config core.hooksPath .githooks

@morehouse morehouse left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably duplicate the [workspace.lints.clippy] and [workspace.lints.rust] sections from Cargo.toml to workloads/ldk/Cargo.toml.

Comment thread .github/workflows/rust.yml
@ekzyis ekzyis changed the title ci: also run fmt/clippy in workloads/ldk ci(ldk): also run fmt/clippy in workloads/ldk Aug 12, 2026
workloads/ldk is a separate workspace, so run fmt and clippy against it,
and cache it, like the root workspace.

We run clippy without --all-features because the workspace has no
features.
@ekzyis

ekzyis commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

I think we should probably duplicate the [workspace.lints.clippy] and [workspace.lints.rust] sections from Cargo.toml to workloads/ldk/Cargo.toml.

Right, I wasn't running clippy with our root workspace rules. Done in 511d8a9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Clippy and rustfmt for the LDK workload in CI

2 participants