ci(ldk): also run fmt/clippy in workloads/ldk - #203
Open
ekzyis wants to merge 1 commit into
Open
Conversation
morehouse
reviewed
Aug 12, 2026
morehouse
left a comment
Collaborator
There was a problem hiding this comment.
I think we should probably duplicate the [workspace.lints.clippy] and [workspace.lints.rust] sections from Cargo.toml to workloads/ldk/Cargo.toml.
ekzyis
force-pushed
the
ci-workloads-ldk
branch
from
August 12, 2026 18:29
6357c91 to
af4cfc1
Compare
workloads/ldk is a separate workspace, so run fmt and clippy against it, and cache it, like the root workspace. We run clippy without --all-features because the workspace has no features.
ekzyis
force-pushed
the
ci-workloads-ldk
branch
from
August 12, 2026 18:33
af4cfc1 to
511d8a9
Compare
Contributor
Author
Right, I wasn't running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #201
Btw, I can recommend running the quick part of the CI locally before committing with git hooks: